Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pruning subcommand #2124

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

paul121
Copy link
Contributor

@paul121 paul121 commented Jan 6, 2024

Description

SDK 0.45 and 0.46 made a pruning subcommand available: cosmos/cosmos-sdk#12742 and cosmos/cosmos-sdk#12727

This command allows you to prune old states on-demand & offline. This is useful because old states are not automatically pruned when you change pruning settings.

I've included the pruning command in the regen root command using this PR as an example: provenance-io/provenance#1209


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d4fd33) 73.26% compared to head (be0c201) 73.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2124   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         232      232           
  Lines       13746    13748    +2     
=======================================
+ Hits        10071    10073    +2     
  Misses       2941     2941           
  Partials      734      734           
Files Coverage Δ
app/client/cli/root.go 61.94% <100.00%> (+0.33%) ⬆️

@aaronc aaronc merged commit 54cb6bb into regen-network:main Jan 8, 2024
32 checks passed
@paul121 paul121 deleted the pruning-subcmd branch January 15, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants