feat(x/ecocredit)!: add ecocredit projects msg & query server implementations #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleem1314
changed the title
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 74.39% 73.91% -0.48%
==========================================
Files 109 110 +1
Lines 16539 17064 +525
==========================================
+ Hits 12304 12613 +309
- Misses 3404 3578 +174
- Partials 831 873 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleem1314
commented
Nov 25, 2021
aleem1314
commented
Nov 25, 2021
|
lgtm, just pending - #647 (comment) |
There was a problem hiding this comment.
Unblocking, but I would like to see:
- better organization and reuse of validation functions
- Remove legacy Msg methods (Route, Type, GetSignBytes) - they are not needed. Let's make the code less boilerplate.
- decide about https://github.com/regen-network/regen-ledger/pull/647/files#r761416527 (@clevinson )
| @@ -549,3 +548,140 @@ func (m *MsgAllowAskDenom) GetSigners() []sdk.AccAddress { | |||
| addr, _ := sdk.AccAddressFromBech32(m.RootAddress) | |||
| return []sdk.AccAddress{addr} | |||
| } | |||
|
|
|||
| // Route implements the LegacyMsg interface. | |||
| func (m MsgCreateProject) Route() string { return sdk.MsgTypeURL(&m) } | |||
There was a problem hiding this comment.
I think we don't need to implement it. Let's remove. Same for Type.
| BatchDenom: string(batchDenom), | ||
| Issuer: req.Issuer, | ||
| TotalAmount: totalSupplyStr, | ||
| StartDate: req.StartDate.Format("2006-01-02"), | ||
| EndDate: req.EndDate.Format("2006-01-02"), | ||
| ProjectLocation: req.ProjectLocation, | ||
| ProjectLocation: projectInfo.ProjectLocation, |
If we remove legacy Msg methods, Ledger users won't be able to sign txns #469. |
clevinson
dismissed
robert-zaremba’s stale review
Robert said he was unblocking - so dismissing
This was referenced Dec 17, 2021
|
should we add a test for the project ID generator ? |
technicallyty
approved these changes
Jan 3, 2022
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
4 tasks
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #646
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change