-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): add minimal basket proto #731
Conversation
d27f707
to
3358f76
Compare
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 74.74% 75.15% +0.41%
==========================================
Files 118 107 -11
Lines 19542 14263 -5279
==========================================
- Hits 14606 10719 -3887
+ Misses 3963 2905 -1058
+ Partials 973 639 -334
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just comment nits
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Few small suggestions/questions that I think we should address before merging. Nothing major.
// a cutoff for batch start dates when adding new credits to the basket. | ||
// Based on the current block timestamp, credits whose start date is before | ||
// block timestamp - batch_date_window will not be allowed into the basket. | ||
google.protobuf.Duration batch_date_window = 8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speaking with @glandua, we should also have the option of the recency filter being a fixed date. This is what we will use for the initial basket RND is creating (2012 min vintage start date)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked with @glandua and we decided to just support fixed start date for now to support to minimal known requirements. Let's add an issue to add support for rolling date windows in the next release.
Co-authored-by: Cory <cjlevinson@gmail.com>
…k/regen-ledger into aaronc/minimal-basket-proto
Pushed several updates. Please re-review @clevinson @technicallyty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking, left few suggestions. I wonder if we should use basket.id
instead of denom
in all the mappings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A couple comments but nothing blocking.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
…o aaronc/minimal-basket-proto
auto-merging to unblock the next pieces |
Description
Minimal basket proto to align with super quick Regen Ledger 2.1 release. To be backported against v2.0.x.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change