feat: add featured projects to registry home #49
Conversation
| of: [ | ||
| { | ||
| type: 'reference', | ||
| to: [{ type: 'project' }], |
There was a problem hiding this comment.
I believe we don't necessarily want a reference to an existing project in Sanity because this means the editor will need to provide project image, location, etc. if the project doesn't already exist while we can easily get this from the marketplace app (contrary to the website at this point), so I guess just a list of strings could be sufficient.
There was a problem hiding this comment.
Using a list of strings here would prevent editors from reusing previously used IDs. Searching a project by name is also a better experience in sanity than having to input an ID manually. By doing so we also capitalize on a single source of truth for a project that could be helpful elsewhere.
There are currently 4 mandatory fields for the project entity in sanity, among those I think we could only keep name and id as mandatory making the project creation almost the same effort as using an id directly but with additional benefits.
There was a problem hiding this comment.
yeah then if we only make name and id required, I agree that works better
| @@ -17,7 +17,7 @@ export default { | |||
| }, | |||
| { | |||
| name: 'projectsSection', | |||
| type: 'titleCustomBody', | |||
| type: 'homePageProjectsSection', | |||
There was a problem hiding this comment.
just a side note that this is breaking and leads to the following error on https://dev.app.regen.network/ and all deploy previews that do not include your code from regen-network/regen-web#2191 until this is merged
so it might be best to make use of sanity graphql tagged endpoints: https://www.sanity.io/docs/graphql#e2e900be2233
There was a problem hiding this comment.
I wasn't aware we could create additional tags like that, will make more use of that in the future if needed.
There was a problem hiding this comment.
I'll create an issue to add a note in the README about that
Description
Part of: regen-network/rnd-dev-team#1811
homePageProjectsSectionhomePagedocumentAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
./deskStructure.jsReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...