feat: use getOfflineSignerOnlyAmino to see human readable message details #1628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #1982
This is an experimental PR.
Keplr does not currently have great support for displaying human-readable proto sign-docs for custom messages.
But their docs indicate that you can use the amino API to achieve this.
This PR does this by always using
getOfflineSignerOnlyAmino
, even for proto messages. I'm not sure if this is the direction we want to go, but it is worth testing and discussing.Before
After
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
redwood
,hambach
and optionallymaster
(see below)Setting up backport PRs
After merging your PR to
dev
, set up backports by doing the following:your PR:
@Mergifyio backport redwood hambach
.@Mergifyio backport redwood hambach master
.If your branch does have merge commits:
a. Pull latest
dev
,hambach
andredwood
branchesb. Create new branches for backports and merge
dev
(replace<PR#>
with your PR #)c. Open new PRs in regen-web targeting
hambach
andredwood
, respectively.d. If PR is a bug fix repeat the same process for
master
branch.How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...