Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use getOfflineSignerOnlyAmino to see human readable message details #1628

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

mhagel
Copy link
Contributor

@mhagel mhagel commented Nov 30, 2022

Description

Related: #1982

This is an experimental PR.

Keplr does not currently have great support for displaying human-readable proto sign-docs for custom messages.
But their docs indicate that you can use the amino API to achieve this.

This PR does this by always using getOfflineSignerOnlyAmino, even for proto messages. I'm not sure if this is the direction we want to go, but it is worth testing and discussing.

Before
Screen Shot 2022-11-30 at 2 56 21 PM

After
Screen Shot 2022-11-30 at 2 55 28 PM


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed
  • once the PR is closed, set up backport PRs for redwood, hambach and optionally master (see below)

Setting up backport PRs

After merging your PR to dev, set up backports by doing the following:

  1. If your branch does not have merge commits, add the following comment to
    your PR:
  • If PR is a new feature: @Mergifyio backport redwood hambach.
  • If PR is a bug fix: @Mergifyio backport redwood hambach master.
  1. If your branch does have merge commits:

    a. Pull latest dev, hambach and redwood branches

    b. Create new branches for backports and merge dev (replace <PR#> with your PR #)

    git checkout -b hambach-backport-<PR#> hambach
    git merge dev
    git push origin hambach-backport-<PR#>
    git checkout -b redwood-backport-<PR#> redwood
    git merge dev
    git push origin redwood-backport-<PR#>`
    

    c. Open new PRs in regen-web targeting hambach and redwood, respectively.

    d. If PR is a bug fix repeat the same process for master branch.

How to test

  1. Test here: https://deploy-preview-1628--regen-registry.netlify.app/

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@mhagel mhagel changed the title chore: use getOfflineSignerOnlyAmino to see human readable message bo… use getOfflineSignerOnlyAmino to see human readable message details Nov 30, 2022
@mhagel mhagel changed the title use getOfflineSignerOnlyAmino to see human readable message details exp: use getOfflineSignerOnlyAmino to see human readable message details Dec 14, 2022
@ryanchristo ryanchristo marked this pull request as ready for review August 1, 2023 15:41
@ryanchristo ryanchristo changed the title exp: use getOfflineSignerOnlyAmino to see human readable message details feat: use getOfflineSignerOnlyAmino to see human readable message details Aug 1, 2023
@blushi blushi self-requested a review August 1, 2023 15:42
@blushi blushi force-pushed the feat-59-human-readable-msg branch from 3619105 to c0202e1 Compare August 2, 2023 08:27
@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit c0202e1
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64ca138f25b55b0008340e7d
😎 Deploy Preview https://deploy-preview-1628--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@blushi blushi merged commit 718aae8 into dev Aug 2, 2023
@blushi blushi deleted the feat-59-human-readable-msg branch August 2, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants