Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to bun #2139

Merged
merged 19 commits into from
Dec 4, 2023
Merged

chore: migrate to bun #2139

merged 19 commits into from
Dec 4, 2023

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Sep 26, 2023

Description

Closes: regen-network/rnd-dev-team#1776

  • migration to Bun
  • Remove Lerna usage and use Bun to manage the monorepo

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 28137dd
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/656da1480d5f0d0008db1c0c
😎 Deploy Preview https://deploy-preview-2139--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede changed the title chore: migrate to 1776 chore: migrate to bun Sep 26, 2023
@aaronc
Copy link
Member

aaronc commented Oct 24, 2023

Seems like Netlify officially supports Bun now: https://docs.netlify.com/configure-builds/manage-dependencies/#bun. Would like to see this get merged and have a modernized workflow

@aaronc
Copy link
Member

aaronc commented Oct 24, 2023

Also happy to pick this up @flagrede if you're busy with other stuff. Seems like it should be relatively straightforward

@flagrede
Copy link
Collaborator Author

@aaronc That's great, I'll try to move forward with this PR today or tomorrow at worst.

@flagrede flagrede force-pushed the chore-1776-bun-upgrade branch 2 times, most recently from b291100 to 033619e Compare October 30, 2023 13:43
@flagrede
Copy link
Collaborator Author

@aaronc I was able to make some progress today, I fixed 2 issues 05fe442 and 046236a
But it seems a bit less straightforward than expected, I'm having issues with lerna commands which don't support the workspace:* prefix now.

@flagrede flagrede force-pushed the chore-1776-bun-upgrade branch 3 times, most recently from 9dfe4ee to 4c479d4 Compare November 7, 2023 14:03
@flagrede
Copy link
Collaborator Author

flagrede commented Nov 7, 2023

Bun is now set up for all packages. The only limitation is that I could not get absolute import to work with web-components (mainly because of storybook) but this could be a follow-up issue.
Also, all Lerna scripts have been replaced by bun commands, we just have to keep Lerna for the version command used to make new releases.

@flagrede flagrede requested a review from a team November 7, 2023 14:43
path.resolve(__dirname, '../../web-components/tsconfig.json'),
path.resolve(__dirname, '../../web-marketplace/tsconfig.json'),
],
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need this?

Copy link
Collaborator Author

@flagrede flagrede Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not get tsconfigPaths to work with the bun migration (it was needed for absolute path to work in storybook). I think it's more related to our configuration rather than a bun-specific issue but as I was saying here this is not blocking and we can investigate it further in a follow-up issue.

@aaronc
Copy link
Member

aaronc commented Nov 7, 2023

Bun is now set up for all packages. The only limitation is that I could not get absolute import to work with web-components (mainly because of storybook) but this could be a follow-up issue.

Found this regarding bun and storybook: oven-sh/bun#3794 (comment)

@flagrede
Copy link
Collaborator Author

flagrede commented Nov 8, 2023

Bun is now set up for all packages. The only limitation is that I could not get absolute import to work with web-components (mainly because of storybook) but this could be a follow-up issue.

Found this regarding bun and storybook: oven-sh/bun#3794 (comment)

Will try to replace the command before merging to see if it works well.

@flagrede flagrede force-pushed the chore-1776-bun-upgrade branch from 23907ce to 28137dd Compare December 4, 2023 09:52
@flagrede flagrede merged commit 5da6b81 into dev Dec 4, 2023
14 checks passed
@flagrede flagrede deleted the chore-1776-bun-upgrade branch December 4, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update our package manager tools
2 participants