-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to bun #2139
chore: migrate to bun #2139
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Seems like Netlify officially supports Bun now: https://docs.netlify.com/configure-builds/manage-dependencies/#bun. Would like to see this get merged and have a modernized workflow |
Also happy to pick this up @flagrede if you're busy with other stuff. Seems like it should be relatively straightforward |
@aaronc That's great, I'll try to move forward with this PR today or tomorrow at worst. |
b291100
to
033619e
Compare
9dfe4ee
to
4c479d4
Compare
Bun is now set up for all packages. The only limitation is that I could not get absolute import to work with |
path.resolve(__dirname, '../../web-components/tsconfig.json'), | ||
path.resolve(__dirname, '../../web-marketplace/tsconfig.json'), | ||
], | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get tsconfigPaths
to work with the bun
migration (it was needed for absolute path to work in storybook). I think it's more related to our configuration rather than a bun-specific issue but as I was saying here this is not blocking and we can investigate it further in a follow-up issue.
Found this regarding bun and storybook: oven-sh/bun#3794 (comment) |
Will try to replace the command before merging to see if it works well. |
23907ce
to
28137dd
Compare
Description
Closes: regen-network/rnd-dev-team#1776
Bun
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...