-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor batches fetching #2152
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
99e9173
to
42b86ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the stats page, for the number of credits at the top, "-" is getting displayed first instead of the loading skeleton
Otherwise looking good
42b86ba
to
421e018
Compare
@blushi thanks for catching the loading issue, this is fixed. |
It might be worth for @erikalogie to test this so we have another person double checking there's no regression, see testing instructions above, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring! It would be great to have @erikalogie to test this as well for any regression but tACK on my side
69c9218
to
c269a6b
Compare
Is it expected that after you click through a few pages, some of the pages of credit batches are missing the tx hash and/or the credit class? |
@erikalogie Yes, I think we already had that on dev. |
Ok then otherwise I believe it looks ok |
c269a6b
to
3f7b02b
Compare
Yeah I think so too, the missing txs are related to an existing limitation: #2152 (comment) (not reproducable on prod yet because we don't have enough credit batches), but the missing credit class could be worth investigating as part of a separate issue |
Description
Closes: regen-network/rnd-dev-team#1800
addDataToBatches
into a hookuseFetchPaginatedBatches
useBatchesWithSupply
(without react-query) byuseFetchPaginatedBatches
(with react-query)getBatchesByIssuerQuery
methodFor reviewers:
In order to look for regressions, I've put links to all pages using credit batches.
Let me know if I missed any.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...