Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add complete tailwind color palette #2183

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Oct 16, 2023

Description

Closes #2180


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit faaf7cf
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/652ea177a2815d00088c4cea
😎 Deploy Preview https://deploy-preview-2183--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aaronc aaronc marked this pull request as ready for review October 16, 2023 19:29
--blue-100: 216 228 245;
}

.dark {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a class here instead of a media query to make testing easier

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could even keep it if we want to add a theme toggle.

Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

--blue-100: 216 228 245;
}

.dark {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could even keep it if we want to add a theme toggle.

@aaronc aaronc enabled auto-merge (squash) October 17, 2023 15:00
@aaronc aaronc merged commit 8eac9b2 into dev Oct 17, 2023
@aaronc aaronc deleted the aaronc/2180-setup-complete-tailwind-color-palette branch October 17, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup complete tailwind color palette
2 participants