Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sitemap to www #2202

Merged
merged 6 commits into from
Nov 7, 2023
Merged

feat: add sitemap to www #2202

merged 6 commits into from
Nov 7, 2023

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Oct 31, 2023

Description

Closes: #2187

  • bump next to v14.0.1
  • add /sitemap.xml endpoint
  • fix type errors

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2202--regen-website.netlify.app/sitemap.xml

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 3f0e533
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6549f89a6782ea0008f9ff91
😎 Deploy Preview https://deploy-preview-2202--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede requested a review from a team October 31, 2023 14:28
@flagrede
Copy link
Collaborator Author

@aaronc here's the sitemap https://deploy-preview-2202--regen-website.netlify.app/sitemap.xml
Let me know if some values need to be changed, wasn't sure about priority and update frequency.

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flagrede. I would set the change frequency to daily across the board. Yearly is way too infrequent. Even if we don't change things too often currently, we should plan on having more frequent updates eventually

@flagrede flagrede requested a review from aaronc November 6, 2023 13:54
@flagrede flagrede force-pushed the feat-2187-www-sitemap branch from f92cff0 to fd812ef Compare November 6, 2023 16:32
@flagrede flagrede force-pushed the feat-2187-www-sitemap branch from fd812ef to 3f0e533 Compare November 7, 2023 08:43
@flagrede flagrede merged commit 3173a95 into dev Nov 7, 2023
11 checks passed
@flagrede flagrede deleted the feat-2187-www-sitemap branch November 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add www sitemap
2 participants