Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buy button on credit class page #2208

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

blushi
Copy link
Member

@blushi blushi commented Nov 8, 2023

Description

Closes: #2207


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Check that the buy button is in the footer of https://deploy-preview-2208--regen-marketplace.netlify.app/credit-classes/C01 or any other credit class page with some sell orders and test it works as expected.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

netlify.toml Outdated
@@ -42,7 +42,7 @@

[context.deploy-preview.environment]
VITE_SANITY_TAG = "default"
VITE_SANITY_DATASET = "staging"
VITE_SANITY_DATASET = "production"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for testing on the deploy preview since this is a hotfix and main doesn't have the sanity graphql API changes
will drop 9f1f83d before merging

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 7a2d952
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6552009c4c3c9b00087c1b08
😎 Deploy Preview https://deploy-preview-2208--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested a review from a team November 8, 2023 08:03
@blushi
Copy link
Member Author

blushi commented Nov 8, 2023

@erikalogie see testing instructions above

@erikalogie
Copy link
Collaborator

@erikalogie see testing instructions above

This looks good, thanks for fixing so quickly!

Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@blushi blushi force-pushed the fix-2207-class-buy-button branch from 9f1f83d to 7a2d952 Compare November 13, 2023 10:55
@blushi blushi merged commit 7a2d952 into main Nov 13, 2023
11 checks passed
@blushi blushi deleted the fix-2207-class-buy-button branch November 13, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants