-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-508 show book call button on terrasos project bottom banner #2565
Conversation
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie @S4mmyb see testing instructions |
LGTM |
LGTM! |
@@ -338,6 +351,8 @@ function ProjectDetails(): JSX.Element { | |||
projectBySlug?.data.projectBySlug?.published; | |||
const projectLocation = projectMetadata?.['schema:location']; | |||
|
|||
const isTerrasos = normalizedProject.type === 'TerrasosProjectInfo'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the IS_TERRASOS
constant from lib/env
in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this isn't the same thing
IS_TERRASOS just means it's the terrasos app, which allows us to use their custom theme and features as on https://terrasos.app.regen.network/
(basically it's just VITE_MARKETPLACE_CLIENT
env var that we need to set to tell the app to run as regen marketplace or terrasos app)
whereas here, we're checking whether a particular project is a terrasos project or not, and we check the @type
value that is stored in the project metadata
44b31fa
to
1960aae
Compare
Description
https://regennetwork.atlassian.net/browse/APP-508
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...