Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-508 show book call button on terrasos project bottom banner #2565

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Nov 27, 2024

Description

https://regennetwork.atlassian.net/browse/APP-508


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. From Terrasos app https://deploy-preview-2565--terrasos.netlify.app/project/biocultural-jaguar-credits-ancestral-stewardship-in-the-sharamentsa-community-2, "Book a call" button for terrasos projects going to terrasos website contact page
  2. "Book a call" button from compliance info tabs is the same https://deploy-preview-2565--terrasos.netlify.app/project/C02-009
  3. From Regen app https://deploy-preview-2565--regen-marketplace.netlify.app/project/354637ec-a687-11ef-b1b2-022e215a294f, "Book a call" button for terrasos projects going to internal calendy
  4. From Regen app, other off chain projects remains without bottom banner https://deploy-preview-2565--regen-marketplace.netlify.app/project/woodburn

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 1960aae
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/674ef61bdc45f20007c09b91
😎 Deploy Preview https://deploy-preview-2565--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 1960aae
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/674ef61b9f997500082a5521
😎 Deploy Preview https://deploy-preview-2565--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Nov 27, 2024

@erikalogie @S4mmyb see testing instructions

@S4mmyb
Copy link
Member

S4mmyb commented Nov 27, 2024

LGTM

@erikalogie
Copy link
Collaborator

LGTM!

@blushi blushi requested a review from r41ph November 28, 2024 09:04
@@ -338,6 +351,8 @@ function ProjectDetails(): JSX.Element {
projectBySlug?.data.projectBySlug?.published;
const projectLocation = projectMetadata?.['schema:location'];

const isTerrasos = normalizedProject.type === 'TerrasosProjectInfo';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the IS_TERRASOS constant from lib/env in this case?

Copy link
Member Author

@blushi blushi Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this isn't the same thing
IS_TERRASOS just means it's the terrasos app, which allows us to use their custom theme and features as on https://terrasos.app.regen.network/
(basically it's just VITE_MARKETPLACE_CLIENT env var that we need to set to tell the app to run as regen marketplace or terrasos app)
whereas here, we're checking whether a particular project is a terrasos project or not, and we check the @type value that is stored in the project metadata

@blushi blushi force-pushed the feat-APP-508-terrasos-book-call branch from 44b31fa to 1960aae Compare December 3, 2024 12:14
@blushi blushi merged commit 7c5dc18 into dev Dec 3, 2024
18 checks passed
@blushi blushi deleted the feat-APP-508-terrasos-book-call branch December 3, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants