This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Token of undefined issue in login #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnabk
reviewed
Aug 12, 2017
| if (!account || !token || !currency) break; | ||
| accounts.push({ account: account, token: token, currency : currency, }); | ||
| if (!account || !token) break; | ||
| accounts.push({ account: account, token: token, currency : currency || '', }); |
Contributor
There was a problem hiding this comment.
@nazaninreihani We might have to think about it more. I have seen this account.currency being used in multiple places. Not sure if it has some major impact allowing to proceed with empty currency. Could you please check the previous code before my changes if it was earlier allowed to pass through with currency being none? That way we would be safe to merge this change
Contributor
|
@nazaninreihani Are you still working on this ? |
Contributor
Author
|
@arnabk I mentioned you before, before the PR of adding currency to login we had SET_DEFAULT_CURRENCY so what's your idea? removing currency or adding SET_DEFAULT_CURRENCY to handle it again? |
Contributor
Author
|
@arnabk is it necessary to include currency in login process? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.