Updates for fs2 v3 #132
Merged
Updates for fs2 v3 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regis-leray
reviewed
Apr 29, 2021
| @@ -72,19 +70,17 @@ final private class UnsecureFtp[F[_]: ConcurrentEffect: ContextShift]( | |||
| ) | |||
|
|
|||
| def execute[T](f: JFTPClient => T): F[T] = | |||
| blocker.delay[F, T](f(unsafeClient)) | |||
| Sync[F].delay(f(unsafeClient)) | |||
There was a problem hiding this comment.
Sync[F].delay is not equivalent to blocker.delay
please use Sync[F].blocking()
|
@regis-leray , Fixed the Sync[F].blocking. Their is one readFile test failing which I am not sure why. Any insight on that would be much helpful. Thanks! |
|
@rehanone thank you maybe a bug in fs2 ? try to open a bug |
|
@rehanone please try new release https://github.com/typelevel/fs2/releases/tag/v3.0.3 |
- Updated `scala-2.13 ` from 2.13.1 to 2.13.5 *Dependencies Updates* - Updated `fs2` dependency from 2.5.0 to 3.0.3 - Updated `scala-collection-compat` dependency from 2.3.2 to 2.4.3 - Updated `commons-net` dependency from 3.7.2 to 3.8.0 *Plugin Updates* - Updated `sbt-scoverage` plugin from 1.6.1 to 1.7.0 - Updated `sbt-sonatype` plugin from 3.9.5 to 3.9.7
|
@regis-leray , I have updated the PR, please review. Thanks. |
regis-leray
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala-2.13from 2.13.1 to 2.13.5Dependencies Updates
fs2dependency from 2.5.0 to 3.0.2scala-collection-compatdependency from 2.3.2 to 2.4.3commons-netdependency from 3.7.2 to 3.8.0Plugin Updates
sbt-scoverageplugin from 1.6.1 to 1.7.0sbt-sonatypeplugin from 3.9.5 to 3.9.7