Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for scala 3. #167

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

rehanone
Copy link
Contributor

@rehanone rehanone commented Oct 8, 2021

Added as WIP as I am not sure what other github workflow changes might be required. This resolves #143.

@regis-leray
Copy link
Owner

Hello thank you again for your contribution.

Im using sbt github action to generate the ./github/workflows/ci.yml by using sbt githubWorkflowGenerate

So every changes your are doing changes in the file build.sbt, you need to run each time sbt githubWorkflowGenerate.

You cannot modify the file :) you let the plugin do the job

https://github.com/djspiewak/sbt-github-actions

@rehanone rehanone force-pushed the support-for-scala3 branch from 35df753 to c99129d Compare October 8, 2021 16:56
@regis-leray
Copy link
Owner

regis-leray commented Oct 8, 2021

try to compile by doing

sbt ++3.0.2 compile

You will get this error

[error] bad option '-Xlint' was ignored
[error] one error found
[error] (Compile / compileIncremental) Compilation failed
[error] Total time: 3 s, completed Oct. 8, 2021, 12:55:53 p.m.

scala3 option changes, you can look inside other repo :) to know which settings are valid

@rehanone
Copy link
Contributor Author

rehanone commented Oct 8, 2021

@regis-leray Thanks, yes I thought I might be making a mistake here. I will make the changes you suggested.

@rehanone rehanone changed the title WIP: Added support for scala 3. Added support for scala 3. Oct 8, 2021
@rehanone
Copy link
Contributor Author

rehanone commented Oct 8, 2021

@regis-leray, Okay it should be good now. Let me know any other items that need to be addressed. Removing the WIP.

build.sbt Outdated
@@ -66,7 +67,7 @@ lazy val `fs2-ftp` = project
"-unchecked",
"-deprecation",
"-feature",
"-Xlint",
// "-Xlint",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a separate rule to have -Xlint activated only for scala2.x but it is not available for scala3
https://docs.scala-lang.org/scala3/guides/migration/options-lookup.html

Example =>
https://github.com/regis-leray/fs2-ftp/blob/master/build.sbt#L75

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added -Xlint for 2.x.

@rehanone rehanone force-pushed the support-for-scala3 branch from c99129d to 2f8b6b7 Compare October 8, 2021 17:33
@rehanone rehanone force-pushed the support-for-scala3 branch from 2f8b6b7 to f297aa1 Compare October 8, 2021 17:38
Copy link
Owner

@regis-leray regis-leray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rehanone thank you

@regis-leray regis-leray merged commit ff26514 into regis-leray:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support scala 3
2 participants