-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for scala 3. #167
Conversation
Hello thank you again for your contribution. Im using sbt github action to generate the So every changes your are doing changes in the file You cannot modify the file :) you let the plugin do the job https://github.com/djspiewak/sbt-github-actions |
35df753
to
c99129d
Compare
try to compile by doing
You will get this error
scala3 option changes, you can look inside other repo :) to know which settings are valid |
@regis-leray Thanks, yes I thought I might be making a mistake here. I will make the changes you suggested. |
@regis-leray, Okay it should be good now. Let me know any other items that need to be addressed. Removing the WIP. |
build.sbt
Outdated
@@ -66,7 +67,7 @@ lazy val `fs2-ftp` = project | |||
"-unchecked", | |||
"-deprecation", | |||
"-feature", | |||
"-Xlint", | |||
// "-Xlint", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a separate rule to have -Xlint
activated only for scala2.x but it is not available for scala3
https://docs.scala-lang.org/scala3/guides/migration/options-lookup.html
Example =>
https://github.com/regis-leray/fs2-ftp/blob/master/build.sbt#L75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added -Xlint
for 2.x.
c99129d
to
2f8b6b7
Compare
2f8b6b7
to
f297aa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rehanone thank you
Added as WIP as I am not sure what other github workflow changes might be required. This resolves #143.