Do not discard exceptions thrown during sftp close #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been having some connection issues, and I believe the
.attempt.flatmap(_ => ...)
may have been throwing away a useful exception.The previous code seems to be using that attempt to ensure that the ssh client gets disconnected at the end, but that is precisely the function of
Resource
.I have a feeling I might be missing some deliberate choice that originally went into this, but I suppose only @regis-leray can answer that.