Skip to content

Commit 1403fa1

Browse files
committed
chore: remove husky 🪓🐶
We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/frontend-app-ora-grading@0.0.1 prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: openedx/frontend-app-learning#1622
1 parent ff72dab commit 1403fa1

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

package-lock.json

Lines changed: 0 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919
"dev": "PUBLIC_PATH=/discussions/ MFE_CONFIG_API_URL='http://localhost:8000/api/mfe_config/v1' fedx-scripts webpack-dev-server --progress --host apps.local.openedx.io",
2020
"test": "fedx-scripts jest --coverage --passWithNoTests"
2121
},
22-
"husky": {
23-
"hooks": {
24-
"pre-commit": "npm run lint"
25-
}
26-
},
2722
"author": "edX",
2823
"license": "AGPL-3.0",
2924
"homepage": "https://github.com/openedx/frontend-app-discussions#readme",
@@ -75,7 +70,6 @@
7570
"babel-plugin-react-intl": "8.2.25",
7671
"eslint-plugin-simple-import-sort": "7.0.0",
7772
"glob": "7.2.0",
78-
"husky": "7.0.4",
7973
"jest": "29.7.0",
8074
"rosie": "2.1.1"
8175
}

0 commit comments

Comments
 (0)