Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST add test for random fraction to keep #1787

Merged
merged 7 commits into from
Aug 8, 2023
Merged

TST add test for random fraction to keep #1787

merged 7 commits into from
Aug 8, 2023

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Aug 8, 2023

xref: conda-forge/aws-sdk-cpp-feedstock#662

This test confirms the current code works if it finds the version. It should have shipped 1.11.132 last week but did not. Thus I think this means that the bot did not find the version. I will check that next

@beckermr
Copy link
Contributor Author

beckermr commented Aug 8, 2023

cc @h-vetinari

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 80.35% and project coverage change: +0.38% 🎉

Comparison is base (32b9c6a) 67.81% compared to head (99ab6b8) 68.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1787      +/-   ##
==========================================
+ Coverage   67.81%   68.20%   +0.38%     
==========================================
  Files          90       90              
  Lines        8555     8600      +45     
==========================================
+ Hits         5802     5866      +64     
+ Misses       2753     2734      -19     
Files Changed Coverage Δ
conda_forge_tick/update_upstream_versions.py 33.57% <35.71%> (-0.81%) ⬇️
tests/test_upstream_versions.py 89.15% <88.23%> (+2.01%) ⬆️
conda_forge_tick/migrators/version.py 65.96% <100.00%> (+4.06%) ⬆️
conda_forge_tick/update_sources.py 67.56% <100.00%> (+5.30%) ⬆️
tests/test_version_migrator.py 98.24% <100.00%> (+0.68%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr beckermr marked this pull request as ready for review August 8, 2023 14:07
@beckermr beckermr merged commit f0997d2 into master Aug 8, 2023
@beckermr beckermr deleted the ver-rand-bug branch August 8, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant