Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest grayskull #1990

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Jan 10, 2024

This is required to work with newer poetry dependency definitions.

@beckermr
Copy link
Contributor

Any idea about the failing test? Does grayskull assume a min of 3.7 for python noarch now?

@xhochy
Copy link
Member Author

xhochy commented Jan 10, 2024

I guess it comes from conda/grayskull#498

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4016c53) 68.74% compared to head (70f4054) 68.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   68.74%   68.71%   -0.03%     
==========================================
  Files          93       93              
  Lines        8756     8756              
==========================================
- Hits         6019     6017       -2     
- Misses       2737     2739       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when you are ready!

@xhochy xhochy marked this pull request as ready for review January 10, 2024 19:12
@xhochy xhochy merged commit fecd027 into regro:master Jan 10, 2024
@xhochy xhochy deleted the update-to-new-grayskull branch January 10, 2024 19:12
@xhochy
Copy link
Member Author

xhochy commented Jan 11, 2024

I can confirm that this fixes my issues with newer poetry based recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants