Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stdlib piggyback to version_migrator #2459

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

h-vetinari
Copy link
Contributor

This was already brought up in #2372, and discussed in today's core call as well (no objection to turning it on despite the limitation about templated output names). Since we haven't had any notable issues I can remember over the last ~2 weeks, I think it's a good time to add it to the version migrator as well now.

Also pick up a drive-by fix for making the sysroot regex pattern catch some more relevant cases.

@h-vetinari
Copy link
Contributor Author

Interestingly, this breaks a few tests that (presumably) expect nothing to happen:

FAILED tests/test_jpeg_libjpeg_turbo.py::test_jpeg_turbo[jpegturbo_pillow_before_meta.yaml-jpegturbo_pillow_after_meta.yaml-9.4.0] - AssertionError: assert {'bot_rerun':...ion': '9.4.0'} == {}
FAILED tests/test_version_migrator.py::test_version_up[numpy-1.24.1] - AssertionError: assert {'bot_rerun':...on': '1.24.1'} == {}
FAILED tests/test_version_migrator.py::test_version_up[python-3.9.5] - AssertionError: assert {'bot_rerun':...ion': '3.9.5'} == {}

@beckermr
Copy link
Contributor

Those look like bad url requests. Let's rety since I think it is unrelated.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.28%. Comparing base (2f73176) to head (31a7540).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2459   +/-   ##
=======================================
  Coverage   71.28%   71.28%           
=======================================
  Files         100      100           
  Lines       10118    10118           
=======================================
  Hits         7213     7213           
  Misses       2905     2905           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr
Copy link
Contributor

LGTM!

Shall we merge @h-vetinari?

@h-vetinari
Copy link
Contributor Author

Alright, let's give this a go! 🚀

@h-vetinari h-vetinari merged commit affef44 into regro:master Apr 18, 2024
5 checks passed
@h-vetinari h-vetinari deleted the stdlib branch April 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants