-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: disable recipe.yaml for migrators #2918
misc: disable recipe.yaml for migrators #2918
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
==========================================
- Coverage 77.08% 76.85% -0.24%
==========================================
Files 112 112
Lines 12050 12133 +83
==========================================
+ Hits 9289 9325 +36
- Misses 2761 2808 +47 ☔ View full report in Codecov by Sentry. |
Can you fill out the PR description to provide the motivation for this one? I can think of easier ways to do this and am curious what the global plan is. |
@beckermr - we wanted to prevent a situation where new feedstocks would somehow trip up migrations. There are a couple places where the Any hints / ideas welcome! |
Thanks @wolfv! That makes sense. Let me think on this a bit. |
@beckermr any new ideas? :) Sorry for the turmoil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries on the turmoil! Thanks for the hard work. So I had a few ideas but I ended up hating all of them. Here is what we should do.
-
This PR has missed some of the migrators (the graph / ABI ones). We should fix that unless it was purposeful in which case we should discuss.
-
Let's make a single tracking issue that has a list of the skipped migrators to figure out if we will enable for v2 and if we do, we can link to the PR.
Hey @beckermr ! sorry if I'm being slow - could you please point me where it is the graph or abi migrator located? |
It is in the file called |
83492e6
to
65ae41f
Compare
@beckermr - I searched but didn't find anything in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't get why this PR doesn't just add statements in the filter functions to bypass v1 recipes.
Description:
This PR prevents situations where new feedstocks would somehow trip up migrations.
Checklist:
Cross-refs, links to issues, etc: