Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: disable recipe.yaml for migrators #2918

Closed

Conversation

nichmor
Copy link

@nichmor nichmor commented Aug 7, 2024

Description:

This PR prevents situations where new feedstocks would somehow trip up migrations.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

@nichmor nichmor changed the title misc: disable meta.yaml for cross_compile.py misc: disable meta.yaml for migrators Aug 7, 2024
@nichmor nichmor changed the title misc: disable meta.yaml for migrators misc: disable recipe.yaml for migrators Aug 7, 2024
conda_forge_tick/utils.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 34.86239% with 71 lines in your changes missing coverage. Please review.

Project coverage is 76.85%. Comparing base (fe8218e) to head (809566e).
Report is 213 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/migrators/arch.py 3.22% 30 Missing ⚠️
conda_forge_tick/migrators/cross_compile.py 33.33% 10 Missing ⚠️
conda_forge_tick/migrators/core.py 33.33% 6 Missing ⚠️
conda_forge_tick/migrators/license.py 33.33% 4 Missing ⚠️
conda_forge_tick/migrators/jinja2_vars_cleanup.py 50.00% 3 Missing ⚠️
conda_forge_tick/migrators/duplicate_lines.py 66.66% 2 Missing ⚠️
..._forge_tick/migrators/extra_jinj2a_keys_cleanup.py 66.66% 2 Missing ⚠️
conda_forge_tick/migrators/pip_check.py 66.66% 2 Missing ⚠️
conda_forge_tick/migrators/pip_wheel_dep.py 33.33% 2 Missing ⚠️
conda_forge_tick/migrators/r_ucrt.py 66.66% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2918      +/-   ##
==========================================
- Coverage   77.08%   76.85%   -0.24%     
==========================================
  Files         112      112              
  Lines       12050    12133      +83     
==========================================
+ Hits         9289     9325      +36     
- Misses       2761     2808      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr
Copy link
Contributor

beckermr commented Aug 7, 2024

Can you fill out the PR description to provide the motivation for this one? I can think of easier ways to do this and am curious what the global plan is.

@wolfv
Copy link
Contributor

wolfv commented Aug 7, 2024

@beckermr - we wanted to prevent a situation where new feedstocks would somehow trip up migrations. There are a couple places where the meta.yaml file is unconditionally loaded.

Any hints / ideas welcome!

@beckermr
Copy link
Contributor

beckermr commented Aug 7, 2024

Thanks @wolfv! That makes sense. Let me think on this a bit.

@nichmor nichmor marked this pull request as ready for review August 8, 2024 08:10
@wolfv
Copy link
Contributor

wolfv commented Aug 8, 2024

@beckermr any new ideas? :) Sorry for the turmoil

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries on the turmoil! Thanks for the hard work. So I had a few ideas but I ended up hating all of them. Here is what we should do.

  1. This PR has missed some of the migrators (the graph / ABI ones). We should fix that unless it was purposeful in which case we should discuss.

  2. Let's make a single tracking issue that has a list of the skipped migrators to figure out if we will enable for v2 and if we do, we can link to the PR.

@nichmor
Copy link
Author

nichmor commented Aug 8, 2024

No worries on the turmoil! Thanks for the hard work. So I had a few ideas but I ended up hating all of them. Here is what we should do.

  1. This PR has missed some of the migrators (the graph / ABI ones). We should fix that unless it was purposeful in which case we should discuss.
  2. Let's make a single tracking issue that has a list of the skipped migrators to figure out if we will enable for v2 and if we do, we can link to the PR.

Hey @beckermr ! sorry if I'm being slow - could you please point me where it is the graph or abi migrator located?

@beckermr
Copy link
Contributor

beckermr commented Aug 8, 2024

It is in the file called core.py in the same module. There appear to a lot of other migrators we have missed. Are those OK? We need to check all of them.

@wolfv wolfv force-pushed the feat/disable-some-migrators-for-recipe-yaml branch from 83492e6 to 65ae41f Compare August 10, 2024 05:58
@wolfv
Copy link
Contributor

wolfv commented Aug 10, 2024

@beckermr - I searched but didn't find anything in core.py.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I don't get why this PR doesn't just add statements in the filter functions to bypass v1 recipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants