Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some mypy issues #3203

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fix some mypy issues #3203

wants to merge 12 commits into from

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Nov 25, 2024

Description:

This PR fixes some mypy issues. Around 180 errors are left.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

@ytausch ytausch requested a review from beckermr November 25, 2024 16:44
@beckermr
Copy link
Contributor

Maybe backout the lockfile changes and try to relock here?

@beckermr
Copy link
Contributor

/relock-conda

@ytausch
Copy link
Contributor Author

ytausch commented Nov 25, 2024

Maybe backout the lockfile changes and try to relock here?

It was just outdated, I can very easily now relock locally as well :D

@ytausch ytausch marked this pull request as ready for review November 25, 2024 16:47
Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have lots of questions on this one. In general, if we are only trying to fix typing issues, then unassociated changes should be in another PR.

conda_forge_tick/make_migrators.py Outdated Show resolved Hide resolved
conda_forge_tick/migration_runner.py Outdated Show resolved Hide resolved
conda_forge_tick/migrators/core.py Show resolved Hide resolved
tests/test_migrators_v1.py Outdated Show resolved Hide resolved
tests/test_migrators.py Outdated Show resolved Hide resolved
mypy.ini Outdated Show resolved Hide resolved
conda_forge_tick/status_report.py Show resolved Hide resolved
conda_forge_tick/migrators/version.py Outdated Show resolved Hide resolved
conda_forge_tick/migrators/version.py Outdated Show resolved Hide resolved
conda_forge_tick/migrators/arch.py Show resolved Hide resolved
@ytausch
Copy link
Contributor Author

ytausch commented Nov 25, 2024

In general, if we are only trying to fix typing issues, then unassociated changes should be in another PR.

I cannot fix typing issues without removing wrongly typed dead code. I also need to change variable assignments minimally if the code is trying to change the type of a variable dynamically. If principles of inheritance are violated, adjustments need to be made to fix them.

There are no "unassociated changes" in this PR.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 71.55963% with 31 lines in your changes missing coverage. Please review.

Project coverage is 78.14%. Comparing base (e555177) to head (5f0df92).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/auto_tick.py 21.05% 15 Missing ⚠️
conda_forge_tick/container_cli.py 0.00% 6 Missing ⚠️
conda_forge_tick/make_migrators.py 20.00% 4 Missing ⚠️
conda_forge_tick/status_report.py 0.00% 2 Missing ⚠️
conda_forge_tick/feedstock_parser.py 75.00% 1 Missing ⚠️
conda_forge_tick/migrators/license.py 75.00% 1 Missing ⚠️
conda_forge_tick/migrators/migration_yaml.py 66.66% 1 Missing ⚠️
conda_forge_tick/migrators/version.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3203      +/-   ##
==========================================
+ Coverage   78.07%   78.14%   +0.07%     
==========================================
  Files         126      126              
  Lines       13708    13702       -6     
==========================================
+ Hits        10702    10707       +5     
+ Misses       3006     2995      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am feeling pretty nervous about merging this PR. Is it possible to break it up into changes that only effect type declarations and into changes that change the code? Then we write some additional tests for the second set of changes, but move the typing ones ahead.

@ytausch
Copy link
Contributor Author

ytausch commented Nov 29, 2024

Next week, @pavelzw and I will make significant progress with #261. Since integration tests would build a lot more confidence in merging changes like this, it's probably worth waiting for that.

I don't think splitting these changes further into "problematic" and "non-problematic" issues is worth the hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants