-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some mypy issues #3203
base: main
Are you sure you want to change the base?
fix some mypy issues #3203
Conversation
Maybe backout the lockfile changes and try to relock here? |
/relock-conda |
It was just outdated, I can very easily now relock locally as well :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have lots of questions on this one. In general, if we are only trying to fix typing issues, then unassociated changes should be in another PR.
I cannot fix typing issues without removing wrongly typed dead code. I also need to change variable assignments minimally if the code is trying to change the type of a variable dynamically. If principles of inheritance are violated, adjustments need to be made to fix them. There are no "unassociated changes" in this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
+ Coverage 78.07% 78.14% +0.07%
==========================================
Files 126 126
Lines 13708 13702 -6
==========================================
+ Hits 10702 10707 +5
+ Misses 3006 2995 -11 ☔ View full report in Codecov by Sentry. |
fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am feeling pretty nervous about merging this PR. Is it possible to break it up into changes that only effect type declarations and into changes that change the code? Then we write some additional tests for the second set of changes, but move the typing ones ahead.
Next week, @pavelzw and I will make significant progress with #261. Since integration tests would build a lot more confidence in merging changes like this, it's probably worth waiting for that. I don't think splitting these changes further into "problematic" and "non-problematic" issues is worth the hassle. |
Description:
This PR fixes some mypy issues. Around 180 errors are left.
Checklist:
Cross-refs, links to issues, etc: