-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch other GH exceptions for no object #3620
Conversation
Co-authored-by: Yannik Tausch <yannik.tausch@quantco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is more to address.
Co-authored-by: Yannik Tausch <yannik.tausch@quantco.com>
done! |
FYI, the bot is currently offline and can't be restarted until we merge this PR. |
What about the remaining comment? Now that we have the type annotation in the type signature we can leave out the second isinstance check. Edit: all clear! |
Yes Sorry I missed that last comment! |
thank you for the prompt code review and great suggestions! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3620 +/- ##
==========================================
- Coverage 77.13% 77.12% -0.01%
==========================================
Files 132 132
Lines 14728 14738 +10
==========================================
+ Hits 11360 11367 +7
- Misses 3368 3371 +3 ☔ View full report in Codecov by Sentry. |
Description:
The GH API changed and we need to catch an additional set of exceptions for testing if files exist.
Checklist:
Cross-refs, links to issues, etc: