Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch other GH exceptions for no object #3620

Merged
merged 7 commits into from
Jan 24, 2025
Merged

fix: catch other GH exceptions for no object #3620

merged 7 commits into from
Jan 24, 2025

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Jan 24, 2025

Description:

The GH API changed and we need to catch an additional set of exceptions for testing if files exist.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Co-authored-by: Yannik Tausch <yannik.tausch@quantco.com>
@beckermr beckermr enabled auto-merge (squash) January 24, 2025 12:15
Copy link
Contributor

@ytausch ytausch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is more to address.

conda_forge_tick/git_utils.py Outdated Show resolved Hide resolved
conda_forge_tick/lazy_json_backends.py Outdated Show resolved Hide resolved
conda_forge_tick/lazy_json_backends.py Outdated Show resolved Hide resolved
conda_forge_tick/lazy_json_backends.py Outdated Show resolved Hide resolved
conda_forge_tick/lazy_json_backends.py Outdated Show resolved Hide resolved
conda_forge_tick/lazy_json_backends.py Outdated Show resolved Hide resolved
@beckermr beckermr disabled auto-merge January 24, 2025 12:27
beckermr and others added 2 commits January 24, 2025 06:28
Co-authored-by: Yannik Tausch <yannik.tausch@quantco.com>
@beckermr
Copy link
Contributor Author

done!

@beckermr
Copy link
Contributor Author

FYI, the bot is currently offline and can't be restarted until we merge this PR.

@ytausch
Copy link
Contributor

ytausch commented Jan 24, 2025

What about the remaining comment? Now that we have the type annotation in the type signature we can leave out the second isinstance check.

Edit: all clear!

@beckermr
Copy link
Contributor Author

Yes Sorry I missed that last comment!

@beckermr
Copy link
Contributor Author

thank you for the prompt code review and great suggestions!

@beckermr beckermr enabled auto-merge (squash) January 24, 2025 12:32
@beckermr beckermr merged commit 847c1aa into main Jan 24, 2025
5 checks passed
@beckermr beckermr deleted the debug-deploy branch January 24, 2025 12:42
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.12%. Comparing base (5925be4) to head (eacad79).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/lazy_json_backends.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3620      +/-   ##
==========================================
- Coverage   77.13%   77.12%   -0.01%     
==========================================
  Files         132      132              
  Lines       14728    14738      +10     
==========================================
+ Hits        11360    11367       +7     
- Misses       3368     3371       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants