Experimental fixes for incomplete record/broadcast when delay set. #812

Garey27 · 2021-02-12T20:59:18Z

Please don't merge before someone test properly.

-Stop demo after new world is appear.

Fix not-initated variable newTarget and newTarget2

…emo.

fred0r · 2021-03-18T03:58:13Z

i'm recording demos for every round played on our server for a few years.
i applied this pull request and compiled rehlds with gcc on a debian10, but the hltv doesnt start - it looks like it has problems parsing its config.
hltv.cfg has delay 60.0.

starting it with:

#/bin/bash
BINARYPATH="$(dirname "${0}")"
cd "${BINARYPATH}"
LIBRARYPATH="$(pwd)"
export LD_LIBRARY_PATH="${LIBRARYPATH}::${LD_LIBRARY_PATH}"
./hltv $@

Console shows:

Console initialized.
FileSystem initialized.
Network initialized.
Master module initialized.
Server module initialized.
World module initialized.
Demo client initialized.
Executing file hltv.cfg.
WARNING! System::DispatchCommand: command "e as shown in score board
" not registered.
WARNING! System::DispatchCommand: command "me "HLTV" " not registered.
WARNING! System::DispatchCommand: command "e as shown in score board
" not registered.
WARNING! System::DispatchCommand: command "should appear in game server browsers
" not registered.
WARNING! System::DispatchCommand: command "Q" not registered.
WARNING! System::DispatchCommand: command "ts - the number of people who can connect to HLTV
etc.......

the same hltv.cfg runs without any problems on the old versions.

Protocol version 48
         Exe version 1.1.2.7/Stdio (cstrike)
         ReHLDS version: 3.8.0.723-dev
         Build date: 22:10:07 Mar 17 2021 (2531)
         Build from: https://github.com/dreamstalker/rehlds/commit/aafde6f

i'm using this amxmodx-plugin.

fred0r · 2021-03-21T07:59:39Z

seems to be just a 'display problem', since commands work, but often followed by that WARNING! System::DispatchCommand: command.
also commands via rcon work.

08:49:16 <01>--- HLTV Status ---
         Online 08:11, FPS 93.7, Version 2531 (Linux)
         Local IP 1.1.1.1:27050, Network In 3.6, Out 2.5, Loss 0.00
         Local Slots 10, Spectators 0 (max 0), Proxies 0
         Total Slots 10, Spectators 0 (max 0), Proxies 1
         Connected to Game Server 1.1.1.1:27015, Delay 60
         Server Name "TV HOST"
         Game Time 08:23, Mod "cstrike", Map "de_nuke.bsp", Players 1

etojuice · 2021-03-21T08:13:29Z

seems to be just a 'display problem', since commands work, but often followed by that WARNING! System::DispatchCommand: command.
also commands via rcon work.

08:49:16 <01>--- HLTV Status ---
         Online 08:11, FPS 93.7, Version 2531 (Linux)
         Local IP 1.1.1.1:27050, Network In 3.6, Out 2.5, Loss 0.00
         Local Slots 10, Spectators 0 (max 0), Proxies 0
         Total Slots 10, Spectators 0 (max 0), Proxies 1
         Connected to Game Server 1.1.1.1:27015, Delay 60
         Server Name "TV HOST"
         Game Time 08:23, Mod "cstrike", Map "de_nuke.bsp", Players 1

use HLTV launcher from earlier builds

fred0r · 2021-03-21T18:35:13Z

i dont get what you are talking about.
could you please point me to this launcher?

[edit]
now using the old hltv-binary from .712, since i had the same problem with .715 and copied all other files.
hltv now runs without errors.
it looks like this behaviour was introduced inbetween .712 und .715.
#821

fred0r · 2021-03-22T18:01:58Z

#821 fixed the problem with the hltv.cfg.
i recompiled and will test these experimental hltv-fixes.

fred0r · 2021-03-23T03:47:41Z

i'm using this amxmodx-plugin.

normaly autohltv_delay in this plugin has to match the hltv-delay value.
hltv runs with delay 60.0 and since this pull request takes care of the current demo/map recorded, i changed the plugin-cvar from autohltv_delay 60 to autohltv_delay 0.

The Demos are recorded just fine, right from the beginning and they end correctly right just before the mapchange.

fred0r · 2021-03-23T22:53:34Z

It sometimes happen, that there are 2 Demofiles recorded for the same map name:

 32K Mär 22 00:00 HLTV-2103220000-de_emir_2015.dem.7z
9,0M Mär 22 00:26 HLTV-2103220001-de_emir_2015.dem.7z
3,4M Mär 22 00:40 HLTV-2103220026-fy_pool_day.dem.7z
969K Mär 22 01:49 HLTV-2103220146-gahhhhh.dem.7z
653K Mär 22 21:02 HLTV-2103222059-mini_dust2.dem.7z
178K Mär 22 22:05 HLTV-2103222204-de_nuke.dem.7z
6,7M Mär 22 22:41 HLTV-2103222217-de_nuke.dem.7z
 14M Mär 22 23:08 HLTV-2103222242-de_dust2.dem.7z
8,5M Mär 22 23:24 HLTV-2103222308-cs_agency_csgo.dem.7z
 12M Mär 22 23:44 HLTV-2103222324-de_dubrovicha.dem.7z
 12M Mär 23 00:05 HLTV-2103222344-de_cocaine.dem.7z
9,6M Mär 23 00:26 HLTV-2103230005-de_parikia_b1.dem.7z
 11M Mär 23 00:47 HLTV-2103230026-de_coldshell_cz.dem.7z
 32K Mär 23 00:47 HLTV-2103230047-de_westtime.dem.7z
7,8M Mär 23 01:07 HLTV-2103230048-de_westtime.dem.7z
6,5M Mär 23 01:26 HLTV-2103230107-de_tpoint.dem.7z

the small demo-files always contain the last 1-2 seconds of the former running map.
for example:
HLTV-2103222204-de_nuke.dem contains the last 1-2 seonds of HLTV-2103222059-mini_dust2.dem.

fred0r · 2021-03-31T00:37:03Z

i changed back to autohltv_delay 60.0, since parts of the beginning of maps were missing.
but even with autohltv_delay 60.0the recorded demos miss the first ~45 sec of the new nextmap.
my server restarts the firstroud after 60 secs, so i personally dont miss anything, but since you said test properly....

fred0r · 2021-04-16T03:30:51Z

Garey27#1

fred0r · 2021-04-17T04:54:00Z

i rechecked some demos created after i wrote 'working fine' (still using that amxx-hltv-plugin):
i've a lot demos which are not recorded correctly.
some demos only spam in console:

Server::ParseVersion: Server is protocol 1074004032 instead of 48
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
Server::ParseVersion: Server is protocol 1074004032 instead of 48
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
Server::ParseVersion: Server is protocol 1074004032 instead of 48
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
Server::ParseVersion: Server is protocol 1074004032 instead of 48
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
Server::ParseVersion: Server is protocol 1074004032 instead of 48
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
Server::ParseVersion: Server is protocol 1074004032 instead of 48
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
Server::ParseVersion: Server is protocol 1074004032 instead of 48
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read

also some demos miss the first few rounds and while trying to view demos, some even just close CS completly.
there seems something wrong.

Garey Akhmetshin added 7 commits February 13, 2021 00:47

Experimental fixes for incomplete record/broadcast when delay set.

a07e88b

-Remove delay in recording demos.

300d03e

-Stop demo after new world is appear.

Don\t check for active demo when setting next world.

1457af4

Fix not-initated variable newTarget and newTarget2

Reconnect democlient with new delayed world system cause twice stop d…

0178d74

…emo.

Fix setting delay to zero when connection active breaking server logic.

da9a5b0

Remove unneeded HLTV_FIXES defines.

00cf3be

Clone signon data between worlds

ca49b33

SergeyShorokhov marked this pull request as draft October 25, 2021 03:15

SergeyShorokhov assigned Garey27 Oct 25, 2021

SergeyShorokhov requested a review from s1lentq October 25, 2021 03:16

SergeyShorokhov added HLTV: Director Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: 🕹️ on hold Task temporarily on hold. Type: 🧬 bug in original HLDS An error that could not be fixed by ReHLDS. labels Oct 25, 2021

s1lentq force-pushed the master branch 2 times, most recently from 43df0ba to de3679f Compare September 20, 2023 14:00

s1lentq force-pushed the master branch from aebfb23 to 93f5775 Compare December 14, 2023 00:40

stamepicmorg force-pushed the master branch from 2d6dfbd to c17dacd Compare November 15, 2024 21:56

stamepicmorg added Engine: 📺 reHLTV Case refers to reHLDS version. and removed HLTV: Director labels Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental fixes for incomplete record/broadcast when delay set. #812

Experimental fixes for incomplete record/broadcast when delay set. #812

Garey27 commented Feb 12, 2021

fred0r commented Mar 18, 2021 •

edited

Loading

fred0r commented Mar 21, 2021 •

edited

Loading

etojuice commented Mar 21, 2021 •

edited

Loading

fred0r commented Mar 21, 2021 •

edited

Loading

fred0r commented Mar 22, 2021

fred0r commented Mar 23, 2021

fred0r commented Mar 23, 2021

fred0r commented Mar 31, 2021

fred0r commented Apr 16, 2021

fred0r commented Apr 17, 2021

Experimental fixes for incomplete record/broadcast when delay set. #812

Are you sure you want to change the base?

Experimental fixes for incomplete record/broadcast when delay set. #812

Conversation

Garey27 commented Feb 12, 2021

fred0r commented Mar 18, 2021 • edited Loading

fred0r commented Mar 21, 2021 • edited Loading

etojuice commented Mar 21, 2021 • edited Loading

fred0r commented Mar 21, 2021 • edited Loading

fred0r commented Mar 22, 2021

fred0r commented Mar 23, 2021

fred0r commented Mar 23, 2021

fred0r commented Mar 31, 2021

fred0r commented Apr 16, 2021

fred0r commented Apr 17, 2021

fred0r commented Mar 18, 2021 •

edited

Loading

fred0r commented Mar 21, 2021 •

edited

Loading

etojuice commented Mar 21, 2021 •

edited

Loading

fred0r commented Mar 21, 2021 •

edited

Loading