TypeError: Class constructor CustomEvent cannot be invoked without 'new'

[cohancarpentier]

When running tests with Jest & running our app on "@rehooks/local-storage": "2.4.1"

Details:

     at new LocalStorageChanged (node_modules/@rehooks/local-storage/src/local-storage-events.ts:21:9)
      at Object.writeStorage (node_modules/@rehooks/local-storage/src/local-storage-events.ts:54:30)
      at create (node_modules/@rehooks/local-storage/src/use-localstorage.ts:89:7)
      at apply (node_modules/react-dom/cjs/react-dom.development.js:23487:20)
      at HTMLUnknownElement.callCallback (node_modules/react-dom/cjs/react-dom.development.js:3945:14)
      at innerInvokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:315:27)
      at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:266:3)
      at HTMLUnknownElementImpl._dispatch (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:212:11)
      at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:87:17)
      at HTMLUnknownElement.dispatchEvent (node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:144:23)

[AndreasGJ]

I have the same error?

[spencerschack]

I am having the same issue. For a quickfix you can rollback to 2.4.0. The breaking behavior was introduced by #67. I think the fix would be to implement the suggestion in this comment: #67 (comment)

[AndreasGJ]

@spencerschack you are a life saver 🥇

[ckknight]

Yep, running into this. Reverting to 2.4.0 works.

[se7entyse7en]

I can confirm that our CI started failing when we updated from 2.4.0 to 2.4.1.

[faradaytrs]

When is that planned to be fixed? 2.4.1 is broken

[amed]

Any update on this?

[maapteh]

@jharrilim is it possible to make at least a working patch version? Everytime when doing a interactive upgrade this lib pops up in not making our build correctly anymore. Its not expectable that using a patch upgrade can give this behaviour. Thanks!

[jharrilim]

I am having the same issue. For a quickfix you can rollback to 2.4.0. The breaking behavior was introduced by #67. I think the fix would be to implement the suggestion in this comment: #67 (comment)

Thanks for suggesting the quickfix!

Any update on this?

I haven't taken a look at this repo in a while so I might be a bit slow to boot, but I shall look into this tonight or sometime this week.

@jharrilim is it possible to make at least a working patch version? Everytime when doing a interactive upgrade this lib pops up in not making our build correctly anymore. Its not expectable that using a patch upgrade can give this behaviour. Thanks!

Agreed, and sorry for the inconvenience. We shall fix this sometime soon.

[jharrilim]

While I wait on getting access to publish to npmjs.com, I have published the 2.4.2 patch to GitHub packages instead, and have also published it under my own scope. Here is how you may use both alternatives:

Switch to @jharrilim/local-storage

Probably the simplest choice, just change your package.json entry that once said:

{
  "dependencies": {
    "@rehooks/local-storage": "^2.4.1"
  }
}

to:

{
  "dependencies": {
    "@jharrilim/local-storage": "^2.4.2"
  }
}

Use the GitHub package

A little more effort, but if it matters, it keeps you pulling from the same org. Add a .npmrc file to your repo if you don't already have one, and ensure it has this line in it:

@rehooks:registry=https://npm.pkg.github.com

[davidcostadev]

Do we have some plans to update the version on the npm?

[jharrilim]

Do we have some plans to update the version on the npm?

Sorry to say it but it doesn't look like I'll be able to do this any time soon:
#78 (comment)
#61 (comment)

As mentioned above, however, I have provided 2 viable solutions that were the best I could do for now. Feel free to use those, or fork this repo if those solutions aren't preferable.

[iamsolankiamit]

@jharrilim the fix is released under 2.4.3 version on npm. I don't have org access to rehooks to add you as a contributor to npm. Didn't focus on this, as I was busy with my day job and don't really use this package anymore. Thanks for keeping it maintained. I'll try to be more active with publishing.

[anark]

I am still seeing this error after upgrading to 2.4.3. Is there anything else that needs to be done to fix this?

[samofwise]

Hey Im also seeing this error on version 2.4.3. Any update on a fix?

[faradaytrs]

@samofwise Same here, problem wasn't fixed in 2.4.3, please reopen @iamsolankiamit

[iamsolankiamit]

Reopening as it seems the issue is not resolved

[quolpr]

Yep, an issue is still here

[ayozemr]

same here, reverting to 2.4.0 works

[mrjackyliang]

installing 2.4.0 works

[j05u3]

@jharrilim the fix is released under 2.4.3 version on npm. I don't have org access to rehooks to add you as a contributor to npm. Didn't focus on this, as I was busy with my day job and don't really use this package anymore. Thanks for keeping it maintained. I'll try to be more active with publishing.

Thanks!
Btw, out of curiosity, do you use another package or another way to handle reactive local storage? or you just meant you don't code this kind of features anymore.

[MichaelBakker1986]

2.4.3 Still same error

 41 |  * on a large library such as Redux.
  42 |  */
  43 | var LocalStorageChanged = /** @class */ (function (_super) {
> 44 |     __extends(LocalStorageChanged, _super);
  45 |     function LocalStorageChanged(payload) {
  46 |         return _super.call(this, LocalStorageChanged.eventName, { detail: payload }) || this;
  47 |     }

[formatlos]

I do get the same error with 2.4.3, reverting back to 2.4.0 works

[giladgo]

Will #80 fix this? Seems that inheriting from CustomEvent was removed there...
I was just wondering... when can we expect the next release to npm? :)

[iamsolankiamit]

@giladgo 2.4.4 should fix this