fix global is not defined in browser #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamsolankiamit @jharrilim Hi maintainers! Could you review/merge it? |
|
If this could be reviewed and merged it would be super helpfull for us. 🙏 |
|
Are there plans to release this soon? We're coming across this as well. |
|
Hey 👋 @iamsolankiamit @jharrilim appreciate you merging this in, is there any chance you could publish an npm release? 🙏 |
|
@field123 released in version https://github.com/rehooks/local-storage/releases/tag/v2.4.5 |
lewisl9029
added a commit
to lewisl9029/highlight
that referenced
this pull request
Jan 16, 2024
Fixes a bug where browser builds references `global`: rehooks/local-storage#93 Allows us to remove a default override to @lewisl9029/rehooks-local-storage on the Reflame side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with v2.4.4,
ReferenceError: global is not definedis happened. CheckisBrowser()on Line:10 so this place is safe to usewindow