Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collapsing lines with plaintext lang with grid true #158

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Jan 16, 2024

plaintext language renders another <span> so the children empty check fails. toString(node) being empty works for both

Fix #157

Copy link

changeset-bot bot commented Jan 16, 2024

⚠️ No Changeset found

Latest commit: a84aab9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for rehype-pretty-code canceled.

Name Link
🔨 Latest commit a84aab9
🔍 Latest deploy log https://app.netlify.com/sites/rehype-pretty-code/deploys/65a6f24d2eab3a0008cc0068

@atomiks atomiks merged commit 20159e2 into master Jan 16, 2024
5 checks passed
@atomiks atomiks deleted the fix/plaintext-collapse branch January 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plaintext does not render empty lines (\n line breaks)
1 participant