-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added a new rehype plugin to plugins.md #185
Conversation
Signed-off-by: Sohab Sk <sksohablocal@gmail.com>
This comment has been minimized.
This comment has been minimized.
Thanks for sharing @ITZSHOAIB ! 🙇 General feedback on what gets included in the plugins list:
source: syntax-tree/hast#24 (comment) For your plugin I'm seeing:
Some additional pointers.
|
Thanks, @ChristianMurphy for a detailed reply.
And regarding test, I will add tests using suggested libraries. Thanks! |
A lot, and the same goes for including polyfills and down leveling to earlier versions of the JavaScript standard.
Version ranges are This does not mean lower default version, the package manager will still default to latest in the range. |
@ChristianMurphy Thanks for the time and effort. I have tried my best to update the package according to your suggestions. Please let me know if anything further required. |
@ChristianMurphy I have added some test cases as well. Thanks! |
Signed-off-by: Sohab Sk <sksohablocal@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 154 163 +9
=========================================
+ Hits 154 163 +9 ☔ View full report in Codecov by Sentry. |
Any update???? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ITZSHOAIB! 👋
Nice to see the tests in place and the build output being more consumable.
Could you fill out the PR template here above, you don't seem to have completed it. That's the last remaining blocker
Not blocker, but would be nice to have.
- Use Node16 resolution https://github.com/ITZSHOAIB/rehype-code-group/blob/e1aea7bbbc0e80f9170fbeaccfeaa9986e3c8e26/tsconfig.json#L6-L7
- Consider widening your version ranges https://github.com/ITZSHOAIB/rehype-code-group/blob/e1aea7bbbc0e80f9170fbeaccfeaa9986e3c8e26/package.json#L34-L37, package managers will choose the latest in range, but allowing lower (down to 0.0 of a release) allows them to deduplicate more if there is a conflict)
Please follow the PR template: write a description / check the checkboxes |
This comment has been minimized.
This comment has been minimized.
Thanks! |
Initial checklist
Description of changes
Added a rehype plugin into the plugins.md file.