Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip a11y fix 11.0.1 #193

Merged
merged 4 commits into from
Dec 19, 2022
Merged

Chip a11y fix 11.0.1 #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
242f35d
Update chip color tokens
benjag Dec 19, 2022
833e634
11.0.1-beta.0
benjag Dec 19, 2022
3f9cc6e
Update chip selected-hover state
benjag Dec 19, 2022
5b84f4f
11.0.1
benjag Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dist/android/colors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<color name="cdr_color_text_button_sale_hover">#ffc7370f</color>
<color name="cdr_color_text_button_sale_active">#ffffffff</color>
<color name="cdr_color_text_button_sale_disabled">#ffffffff</color>
<color name="cdr_color_text_chip_default">#ff4e4d49</color>
<color name="cdr_color_text_chip_default">#bf0c0b08</color>
<color name="cdr_color_text_chip_disabled">#ffd1cbbd</color>
<color name="cdr_color_text_primary">#bf0c0b08</color>
<color name="cdr_color_text_secondary">#bf423b2f</color>
Expand Down Expand Up @@ -74,12 +74,13 @@
<color name="cdr_color_background_button_icon_only_active">#fff4f2ed</color>
<color name="cdr_color_background_chip_default_rest">#ffffffff</color>
<color name="cdr_color_background_chip_default_disabled">#ffffffff</color>
<color name="cdr_color_background_chip_default_hover">#fff9f8f6</color>
<color name="cdr_color_background_chip_default_hover">#fff4f2ed</color>
<color name="cdr_color_background_chip_default_focus">#ffffffff</color>
<color name="cdr_color_background_chip_default_active">#ffedeae3</color>
<color name="cdr_color_background_chip_default_selected">#ffedeae3</color>
<color name="cdr_color_background_chip_default_selected">#ffdcd6cb</color>
<color name="cdr_color_background_chip_default_selected_hover">#ffedeae3</color>
<color name="cdr_color_background_chip_default_selected_focus">#ffedeae3</color>
<color name="cdr_color_background_chip_default_selected_focus">#ffdcd6cb</color>
<color name="cdr_color_background_chip_default_selected_active">#ffedeae3</color>
<color name="cdr_color_background_primary">#ffffffff</color>
<color name="cdr_color_background_secondary">#fff4f2ed</color>
<color name="cdr_color_background_brand_spruce">#ff1f513f</color>
Expand Down
1 change: 1 addition & 0 deletions dist/ios/CdrColor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ CdrColorBackgroundChipDefaultActive,
CdrColorBackgroundChipDefaultSelected,
CdrColorBackgroundChipDefaultSelectedHover,
CdrColorBackgroundChipDefaultSelectedFocus,
CdrColorBackgroundChipDefaultSelectedActive,
CdrColorBackgroundPrimary,
CdrColorBackgroundSecondary,
CdrColorBackgroundBrandSpruce,
Expand Down
7 changes: 4 additions & 3 deletions dist/ios/CdrColor.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ + (NSArray *)values {
[UIColor colorWithRed:0.780f green:0.216f blue:0.059f alpha:1.000f],
[UIColor colorWithRed:1.000f green:1.000f blue:1.000f alpha:1.000f],
[UIColor colorWithRed:1.000f green:1.000f blue:1.000f alpha:1.000f],
[UIColor colorWithRed:0.306f green:0.302f blue:0.286f alpha:1.000f],
[UIColor colorWithRed:0.047f green:0.043f blue:0.031f alpha:0.749f],
[UIColor colorWithRed:0.820f green:0.796f blue:0.741f alpha:1.000f],
[UIColor colorWithRed:0.047f green:0.043f blue:0.031f alpha:0.749f],
[UIColor colorWithRed:0.259f green:0.231f blue:0.184f alpha:0.749f],
Expand Down Expand Up @@ -92,11 +92,12 @@ + (NSArray *)values {
[UIColor colorWithRed:0.957f green:0.949f blue:0.929f alpha:1.000f],
[UIColor colorWithRed:1.000f green:1.000f blue:1.000f alpha:1.000f],
[UIColor colorWithRed:1.000f green:1.000f blue:1.000f alpha:1.000f],
[UIColor colorWithRed:0.976f green:0.973f blue:0.965f alpha:1.000f],
[UIColor colorWithRed:0.957f green:0.949f blue:0.929f alpha:1.000f],
[UIColor colorWithRed:1.000f green:1.000f blue:1.000f alpha:1.000f],
[UIColor colorWithRed:0.929f green:0.918f blue:0.890f alpha:1.000f],
[UIColor colorWithRed:0.863f green:0.839f blue:0.796f alpha:1.000f],
[UIColor colorWithRed:0.929f green:0.918f blue:0.890f alpha:1.000f],
[UIColor colorWithRed:0.929f green:0.918f blue:0.890f alpha:1.000f],
[UIColor colorWithRed:0.863f green:0.839f blue:0.796f alpha:1.000f],
[UIColor colorWithRed:0.929f green:0.918f blue:0.890f alpha:1.000f],
[UIColor colorWithRed:1.000f green:1.000f blue:1.000f alpha:1.000f],
[UIColor colorWithRed:0.957f green:0.949f blue:0.929f alpha:1.000f],
Expand Down
9 changes: 5 additions & 4 deletions dist/js/cdr-tokens.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = {
CdrColorTextButtonSaleHover: "#c7370f",
CdrColorTextButtonSaleActive: "#ffffff",
CdrColorTextButtonSaleDisabled: "#ffffff",
CdrColorTextChipDefault: "#4e4d49",
CdrColorTextChipDefault: "rgba(12, 11, 8, 0.75)",
CdrColorTextChipDisabled: "#d1cbbd",
CdrColorTextPrimary: "rgba(12, 11, 8, 0.75)",
CdrColorTextSecondary: "rgba(66, 59, 47, 0.75)",
Expand Down Expand Up @@ -71,12 +71,13 @@ module.exports = {
CdrColorBackgroundButtonIconOnlyActive: "#f4f2ed",
CdrColorBackgroundChipDefaultRest: "#ffffff",
CdrColorBackgroundChipDefaultDisabled: "#ffffff",
CdrColorBackgroundChipDefaultHover: "#f9f8f6",
CdrColorBackgroundChipDefaultHover: "#f4f2ed",
CdrColorBackgroundChipDefaultFocus: "#ffffff",
CdrColorBackgroundChipDefaultActive: "#edeae3",
CdrColorBackgroundChipDefaultSelected: "#edeae3",
CdrColorBackgroundChipDefaultSelected: "#dcd6cb",
CdrColorBackgroundChipDefaultSelectedHover: "#edeae3",
CdrColorBackgroundChipDefaultSelectedFocus: "#edeae3",
CdrColorBackgroundChipDefaultSelectedFocus: "#dcd6cb",
CdrColorBackgroundChipDefaultSelectedActive: "#edeae3",
CdrColorBackgroundPrimary: "#ffffff",
CdrColorBackgroundSecondary: "#f4f2ed",
CdrColorBackgroundBrandSpruce: "#1f513f",
Expand Down
9 changes: 5 additions & 4 deletions dist/js/cdr-tokens.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const CdrColorTextButtonSale = "#ffffff";
export const CdrColorTextButtonSaleHover = "#c7370f";
export const CdrColorTextButtonSaleActive = "#ffffff";
export const CdrColorTextButtonSaleDisabled = "#ffffff";
export const CdrColorTextChipDefault = "#4e4d49";
export const CdrColorTextChipDefault = "rgba(12, 11, 8, 0.75)";
export const CdrColorTextChipDisabled = "#d1cbbd";
export const CdrColorTextPrimary = "rgba(12, 11, 8, 0.75)";
export const CdrColorTextSecondary = "rgba(66, 59, 47, 0.75)";
Expand Down Expand Up @@ -70,12 +70,13 @@ export const CdrColorBackgroundButtonDefaultDisabled = "#dcd6cb";
export const CdrColorBackgroundButtonIconOnlyActive = "#f4f2ed";
export const CdrColorBackgroundChipDefaultRest = "#ffffff";
export const CdrColorBackgroundChipDefaultDisabled = "#ffffff";
export const CdrColorBackgroundChipDefaultHover = "#f9f8f6";
export const CdrColorBackgroundChipDefaultHover = "#f4f2ed";
export const CdrColorBackgroundChipDefaultFocus = "#ffffff";
export const CdrColorBackgroundChipDefaultActive = "#edeae3";
export const CdrColorBackgroundChipDefaultSelected = "#edeae3";
export const CdrColorBackgroundChipDefaultSelected = "#dcd6cb";
export const CdrColorBackgroundChipDefaultSelectedHover = "#edeae3";
export const CdrColorBackgroundChipDefaultSelectedFocus = "#edeae3";
export const CdrColorBackgroundChipDefaultSelectedFocus = "#dcd6cb";
export const CdrColorBackgroundChipDefaultSelectedActive = "#edeae3";
export const CdrColorBackgroundPrimary = "#ffffff";
export const CdrColorBackgroundSecondary = "#f4f2ed";
export const CdrColorBackgroundBrandSpruce = "#1f513f";
Expand Down
42 changes: 34 additions & 8 deletions dist/json/android.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@
}
},
{
"value": "#ff4e4d49",
"value": "#bf0c0b08",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -442,7 +442,7 @@
"description": "Text color for default chips"
},
"original": {
"value": "{options.color.warm-grey-900.value}",
"value": "{options.color.warm-grey-900-75.value}",
"category": "color",
"docs": {
"category": "colors",
Expand Down Expand Up @@ -1889,7 +1889,7 @@
}
},
{
"value": "#fff9f8f6",
"value": "#fff4f2ed",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -1898,7 +1898,7 @@
"description": "Background color for hovered chips"
},
"original": {
"value": "{options.color.warm-grey-100.value}",
"value": "{options.color.warm-grey-200.value}",
"category": "color",
"docs": {
"category": "colors",
Expand Down Expand Up @@ -1967,7 +1967,7 @@
}
},
{
"value": "#ffedeae3",
"value": "#ffdcd6cb",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -1976,7 +1976,7 @@
"description": "Background color for selected chips"
},
"original": {
"value": "{options.color.warm-grey-300.value}",
"value": "{options.color.warm-grey-400.value}",
"category": "color",
"docs": {
"category": "colors",
Expand Down Expand Up @@ -2019,7 +2019,7 @@
}
},
{
"value": "#ffedeae3",
"value": "#ffdcd6cb",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -2028,7 +2028,7 @@
"description": "Background color for focused selected chips"
},
"original": {
"value": "{options.color.warm-grey-300.value}",
"value": "{options.color.warm-grey-400.value}",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -2044,6 +2044,32 @@
"category": "color"
}
},
{
"value": "#ffedeae3",
"category": "color",
"docs": {
"category": "colors",
"type": "chip",
"example": "color",
"description": "Background color for active selected chips"
},
"original": {
"value": "{options.color.warm-grey-300.value}",
"category": "color",
"docs": {
"category": "colors",
"type": "chip",
"example": "color",
"description": "Background color for active selected chips"
}
},
"name": "cdr_color_background_chip_default_selected_active",
"attributes": {
"option": false,
"deprecated": false,
"category": "color"
}
},
{
"value": "#ffffffff",
"category": "color",
Expand Down
42 changes: 34 additions & 8 deletions dist/json/global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@
}
},
{
"value": "#4e4d49",
"value": "rgba(12, 11, 8, 0.75)",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -442,7 +442,7 @@
"description": "Text color for default chips"
},
"original": {
"value": "{options.color.warm-grey-900.value}",
"value": "{options.color.warm-grey-900-75.value}",
"category": "color",
"docs": {
"category": "colors",
Expand Down Expand Up @@ -1889,7 +1889,7 @@
}
},
{
"value": "#f9f8f6",
"value": "#f4f2ed",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -1898,7 +1898,7 @@
"description": "Background color for hovered chips"
},
"original": {
"value": "{options.color.warm-grey-100.value}",
"value": "{options.color.warm-grey-200.value}",
"category": "color",
"docs": {
"category": "colors",
Expand Down Expand Up @@ -1967,7 +1967,7 @@
}
},
{
"value": "#edeae3",
"value": "#dcd6cb",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -1976,7 +1976,7 @@
"description": "Background color for selected chips"
},
"original": {
"value": "{options.color.warm-grey-300.value}",
"value": "{options.color.warm-grey-400.value}",
"category": "color",
"docs": {
"category": "colors",
Expand Down Expand Up @@ -2019,7 +2019,7 @@
}
},
{
"value": "#edeae3",
"value": "#dcd6cb",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -2028,7 +2028,7 @@
"description": "Background color for focused selected chips"
},
"original": {
"value": "{options.color.warm-grey-300.value}",
"value": "{options.color.warm-grey-400.value}",
"category": "color",
"docs": {
"category": "colors",
Expand All @@ -2044,6 +2044,32 @@
"category": "color"
}
},
{
"value": "#edeae3",
"category": "color",
"docs": {
"category": "colors",
"type": "chip",
"example": "color",
"description": "Background color for active selected chips"
},
"original": {
"value": "{options.color.warm-grey-300.value}",
"category": "color",
"docs": {
"category": "colors",
"type": "chip",
"example": "color",
"description": "Background color for active selected chips"
}
},
"name": "cdr-color-background-chip-default-selected-active",
"attributes": {
"option": false,
"deprecated": false,
"category": "color"
}
},
{
"value": "#ffffff",
"category": "color",
Expand Down
Loading