Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

membership palette v1 #210

Merged
merged 5 commits into from
Oct 28, 2024
Merged

membership palette v1 #210

merged 5 commits into from
Oct 28, 2024

Conversation

mhewson
Copy link
Member

@mhewson mhewson commented Oct 23, 2024

@sikhote
Copy link
Contributor

sikhote commented Oct 23, 2024

To poke and prod—are these colors not for global use, only for the rei site? Do they get picked up and used within say, the doc site, in the same way as global? I'm not sure what the downstream effects are of the themes since I have not dug into them as much.

@mhewson
Copy link
Member Author

mhewson commented Oct 24, 2024

To poke and prod—are these colors not for global use, only for the rei site? Do they get picked up and used within say, the doc site, in the same way as global? I'm not sure what the downstream effects are of the themes since I have not dug into them as much.

Its an interesting thought, we designed palettes to be unique to a theme. While the doc site may need to display the rei.com palette as an example of how it is used within REI the doc site itself does not have a membership palette as there are no native doc site use cases to build anything using that palette.
It does however have a supported palette, knockout, which is unique to that theme.

our global tokens are the generic bases and all generics are distributed to all themes - this needs some refinement especially as we move to reduce the amount of component specific tokens. Today I would say that all alias tokens are shared globally to all themes
Themes can modify the alias tokens mapping new options specific to the theme
Themes can add new alias tokens specific to the theme
Themes can extend options

palettes are enabled to map new values to alias and component specific tokens but are not allowed to create unidentified tokens that do not exist in the global space.

@sikhote
Copy link
Contributor

sikhote commented Oct 25, 2024

Some of the colors are being placed into platform-tokens.json within the misc category...checking more into it, but that was causing some oddness on the doc site.

@sikhote
Copy link
Contributor

sikhote commented Oct 28, 2024

Looks good here:
https://cedar-site-nuxt-19d184.gitlab.io/

@mhewson mhewson merged commit 1c001a9 into next Oct 28, 2024
1 check passed
@mhewson mhewson deleted the pr/membership branch October 28, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants