-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
membership palette v1 #210
Conversation
To poke and prod—are these colors not for global use, only for the rei site? Do they get picked up and used within say, the doc site, in the same way as global? I'm not sure what the downstream effects are of the themes since I have not dug into them as much. |
Its an interesting thought, we designed palettes to be unique to a theme. While the doc site may need to display the rei.com palette as an example of how it is used within REI the doc site itself does not have a membership palette as there are no native doc site use cases to build anything using that palette. our global tokens are the generic bases and all generics are distributed to all themes - this needs some refinement especially as we move to reduce the amount of component specific tokens. Today I would say that all alias tokens are shared globally to all themes palettes are enabled to map new values to alias and component specific tokens but are not allowed to create unidentified tokens that do not exist in the global space. |
Some of the colors are being placed into |
Looks good here: |
Here is v1 of our membership tokens