Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP vue 3 update #1013

Closed
wants to merge 54 commits into from
Closed

WIP vue 3 update #1013

wants to merge 54 commits into from

Conversation

cowills
Copy link
Contributor

@cowills cowills commented Mar 23, 2021 •
edited
Loading

Dev/Build

  • dev env
  • linter
  • code coverage
  • unit
  • e2e
  • prod build
  • tree shaking
  • CSS modules
  • ⛔️ typescript defs (postponing TS till vue ecosystem settles)

Integration

  • febs
  • vunit
  • fedpack
  • climbers
  • @rei/component

Components

  • accordion
  • alert
  • breadcrumb
  • button
  • caption
  • card
  • checkbox
  • chips
  • formGroup
  • formError
  • grid
  • row/col
  • icon
  • icon generator
  • image
  • input
  • labelStandalone
  • labelWrapper
  • link
  • list
  • modal
  • pagination
  • popover
  • popup
  • quote
  • radio
  • rating
  • select
  • table
  • tabs
  • text
  • tooltip

mhewson
mhewson previously approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@mhewson mhewson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love a walk through

@cowills
Copy link
Contributor Author

cowills commented Apr 21, 2021

would love a walk through

watch the vue mastery composition API stuff first 🤓

@cowills
Copy link
Contributor Author

cowills commented Apr 28, 2021

currently blocked by this tree shaking issue in the vue compiler vuejs/core#2860

cowills added 17 commits April 28, 2021 12:34
@cowills
fix(accordion): fix accordion, add changes from next, improve accordi…
5342af8 
…onGroup tests
@cowills
chore(test): clean up test warnings
f6b9c1a
@cowills
chore(select): update select, fix tests
c9ca9df
@cowills
chore(radio): clean up radio tests
cf6384a
@cowills
chore(popup): update popup tests
14a48cb
@cowills
chore(tabs): clean up tab panel
831f128
@cowills
chore(popover): update popover formatting, tests
f8f9659
@cowills
chore(popups): clean up tooltips, fix bugs in popover/popup
c24ffda
@cowills
chore(modal): update modal
ddcf808
@cowills
WIP(pagination): wip pagination migration
7cd21b4
@cowills
chore(pagination): update pagination
3a5eb16
@cowills
chore(tabs): update tabpanel
974017e
@cowills
WIP(vue3): wip vue 3 work
42229be
@cowills
fix(test): fix handling of provide/inject in tests
154a433
@cowills
WIP(tabs): wip tabs migration
7db9a9b
@cowills
fix(accordion): fix accordion style logic
bed9e5b
@cowills
fix(dev): fix dev router, tabs example
5c522c5
@cowills cowills closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhewson mhewson mhewson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cowills @mhewson