Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 for fluid space variables #184

Merged
merged 3 commits into from
Jun 26, 2024
Merged

V1 for fluid space variables #184

merged 3 commits into from
Jun 26, 2024

Conversation

mhewson
Copy link
Member

@mhewson mhewson commented Jun 20, 2024

Description

This update provides some support for cdr-space-scale-(N) fluid space
these values seek to mimic were possible the values provided in our spacing design foundation
values were calculated via:
https://utopia.fyi/space/calculator/?c=320,16,1.2,1232,20,1.25,7,1,&s=0.75%7C0.5%7C0.25%7C0.2%7C0.15%7C0.25%7C0.2,1.5%7C2%7C3%7C4%7C6,s-l&g=s,l,xl,12
that URL can also be used to extend or modify future spacing values

...

Checklist:

Design:

  • Reviewed with designer and meets expectations

Cross-browser testing:

  • Chrome
  • Firefox
  • Edge
  • Safari
  • iOS
  • Android

Unit testing:

  • Sufficient unit test coverage (see unit test best practices for ideas)
  • Snapshot updates are explained with comment and reference the relevant source code change

A11y:

  • Meets WCAG AA standards

Documentation:

  • API docs created/updated
  • Examples created/updated

@mhewson mhewson requested a review from sikhote June 20, 2024 05:21
@mhewson mhewson merged commit 8d7669b into v15.1 Jun 26, 2024
@mhewson mhewson deleted the fluid-space branch June 26, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant