Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viz: change default shown target to “Incident Deaths” #1536

Closed
ydhuang28 opened this issue Sep 24, 2020 · 1 comment · Fixed by #1538
Closed

Viz: change default shown target to “Incident Deaths” #1536

ydhuang28 opened this issue Sep 24, 2020 · 1 comment · Fixed by #1538
Assignees
@ydhuang28
Labels
viz

Comments

@ydhuang28
Copy link
Contributor

In order for data to be available when the visualization does the initial plot, the data has to be explicitly loaded in actions.js through data.js. Once this change is made we can then default to showing whichever target we'd like (in this case incident deaths).
@ydhuang28 ydhuang28 self-assigned this Sep 24, 2020
@ydhuang28 ydhuang28 added the viz label Sep 24, 2020
@ydhuang28 ydhuang28 mentioned this issue Sep 24, 2020
Merged
@ydhuang28
Copy link
Contributor Author

@nickreich @hannanabdul55 This is the issue that I was referring to in Slack. I'll make a new pull request and this should be fixed!

@ydhuang28 ydhuang28 linked a pull request Sep 24, 2020 that will close this issue
Resolves #1536 #1538
Merged
ydhuang28 pushed a commit that referenced this issue Sep 24, 2020
Merge pull request #1538 from reichlab/feature_add-inc-case-forecasts
937750b 
Resolves #1536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ydhuang28 ydhuang28

Labels
viz
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #1536 reichlab/covid19-forecast-hub
1 participant
@ydhuang28