Bsweger/hotfix cladetime #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're fixing up cladetime to get a proper test case added for the scenario that caused the error, but in the meantime, let's use the hotfix so we can get the latest data uploaded to S3
This will make it easier to manually recreate a prior run in the event of a problem
bsweger
commented
Dec 2, 2024
| @@ -17,7 +17,7 @@ | |||
| # requires-python = "==3.12" | |||
| # dependencies = [ | |||
| # "click", | |||
| # "cladetime@git+https://github.com/reichlab/cladetime" | |||
| # "cladetime@git+https://github.com/reichlab/cladetime@elr/use_metadata_url" | |||
There was a problem hiding this comment.
bsweger
commented
Dec 2, 2024
| @@ -4,6 +4,11 @@ on: | |||
| schedule: | |||
| - cron: "37 04 * * 1" # 4:37 AM UTC every Mon | |||
| workflow_dispatch: | |||
| inputs: | |||
There was a problem hiding this comment.
Allowing someone to pass in YYYY-MM-DD when running this workflow manually makes it easier to recover in the event of an error.
In this case, I think we can pass in the dates of the failed runs:
2024-10-25: not the current date, so script will set the time to 11:59 PM (i.e., will include info from the 10/25 Nextstrain run)2024-12-02: is today, so script will use the action's run time as the as_of timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a problem reported by @trobacker: https://reichlab.slack.com/archives/C06ESFN6Y79/p1733154604469869
The root cause is the same Cladetime issue that @elray1 and @zkamvar hotfixed last week
There are two commits:
mainbranch)