-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashed right away #2
Comments
… TCP messages from 256 to 2048 bytes. Fix for #2 hopefully.
Thanks for the detailed report! I think I've reproduced the crash you got. I believe Kanata sent a lot of data over TCP when the connection began, overflowing my buffer to accept it. The Kanata TCP functionality is still very much in flux, so the documentation isn't mature on what to expect on my end. I've pushed 787e878 to increase the buffer size to handle the longest message I can imagine Kanata ever sending, and I'll fine-tune this value as Kanata matures. I believe I have also tracked down the issue causing your U_NEW layer to show up. I'm assuming it's in a multi-line comment block ("#| ... |#")? I've pushed b88401d to allow kanata_helper_daemon to handle multiline comments. Long-term, while the functionality to read layer names will probably remain in the code as a fallback mechanism, Kanata has added functionality to send layer names over TCP and save me the trouble of parsing the file. As soon as that functionality is released I'll work it into kanata_helper_daemon. Release v0.1.3 contains these bugfixes. Please let me know if the new release fixes both of your issues. |
Thanks for your prompt response! You are correct about the multi line comments. I'll check and get back to you. I also have a feature request, will post separately. |
I do have a layer called U_NEW, but's a dummy template layer, commented out.
win10, fully patched.
On second try it worked.
The text was updated successfully, but these errors were encountered: