Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the circuit receive arbitrary number of variables #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

batmendbar
Copy link
Contributor

No description provided.

Copy link

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct! But I think we can make it nicer and more obvious to the reader – see comments inline

main.go Outdated
GiCoeffs [][]frontend.Variable `gnark:"G_i Coefficients"`
}

func check01 (api frontend.API, result frontend.Variable, polyCoeffs []frontend.Variable) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function needs a better name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed the function

main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@batmendbar batmendbar requested a review from kustosz August 7, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants