Make clippy happy #140
Merged
Make clippy happy #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margold
commented
Jul 13, 2022
| @@ -80,14 +81,18 @@ where | |||
| { | |||
| use std::ops::Deref; | |||
| let mut template_str = String::new(); | |||
| template_str.push_str(&format!("{} ", LOG_PREFIX_INFO.deref())); | |||
There was a problem hiding this comment.
this was the specific lint: https://rust-lang.github.io/rust-clippy/master/index.html#format_push_string
not sure if this is the best way to fix it
There was a problem hiding this comment.
This lint is problematic because of the way the proposed fix introduces fallibility (see discussion and restriction). Still, this change should be fine here.
dan-ri
approved these changes
Jul 15, 2022
| @@ -80,14 +81,18 @@ where | |||
| { | |||
| use std::ops::Deref; | |||
| let mut template_str = String::new(); | |||
| template_str.push_str(&format!("{} ", LOG_PREFIX_INFO.deref())); | |||
There was a problem hiding this comment.
This lint is problematic because of the way the proposed fix introduces fallibility (see discussion and restriction). Still, this change should be fine here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy is failing on master, I think due to a rust update? Attempting to fix.