Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add installed commands to path #16

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: Add installed commands to path #16

merged 1 commit into from
Mar 12, 2024

Conversation

reitzig
Copy link
Owner

@reitzig reitzig commented Mar 12, 2024

fixes #12

@reitzig
Copy link
Owner Author

reitzig commented Mar 12, 2024

@flyx, can you please confirm that this fixes your issue?

@reitzig reitzig self-assigned this Mar 12, 2024
@reitzig reitzig force-pushed the fix/commands-to-path branch from 6b20616 to 026b99b Compare March 12, 2024 00:50
flyx
flyx approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@flyx flyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, it does fix the issue.

Since tlmgr path add creates symlinks (instead of e.g. only modifying PATH) it's also fine to only run it when packages change. So I see no problems with this.

@reitzig
Copy link
Owner Author

reitzig commented Mar 12, 2024

Cool, thank you! 👍️

And thanks and credits to @koppor , who accidentally provided the correct solution to this issue. <3

@reitzig reitzig removed their assignment Mar 12, 2024
@reitzig reitzig merged commit 493cf86 into master Mar 12, 2024
3 checks passed
@reitzig reitzig deleted the fix/commands-to-path branch March 12, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyx flyx flyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tools installed with tlmgr are not in PATH
2 participants
@reitzig @flyx