-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create symlink for emacsclient in use! method. #34
base: master
Are you sure you want to change the base?
Conversation
Not sure. There are other binaries in the same directory as
I think it should work. I don't know, I don't use it myself, except that Magit uses it to commit. |
Another solution is to link Evm's |
I like this last option. I'm going to try it and update the PR. |
Evm's I'll try to implement the first option, add |
Ahh, right. Too bad, I liked that approach better. Try the first option and we'll so how it goes then.
Take a look here: https://github.com/rejeep/evm/blob/master/lib/evm/package.rb#L17-L23 |
aha, but are there the rest of binaries there? |
Sorry, no. They are in |
I updated the branch. Well, with this way, I think that something to clear the
Another approach could be have a whitelist for binaries, and only symlink them. wdyt? Besides this, there is something I don't understand: Why do you create the additional symlink |
Sound good to me!
Because some people don't want the Also, could you add/update the specs please. |
I'd also like to be able to use emacsclient via EVM. Is it intentional to link all binaries? Looks like the last update was to whitelist. @areina are you able to update this for the current code base or shall I open a new PR? |
I started to use evm in linux and the emacsclient binary is not present. The PR solves this.
@rejeep, I'm not totally convinced with this approach, If you have a better idea I will be happy to modify this PR.
I'll add specs after receiving your feedback. Thanks!
ps: I'm not 100% sure, but emacsclient in mac osx is not working well, right?