Skip to content

Commit

Permalink
Disable flaky AudioKeepsFlowingAfterImplicitRollback test.
Browse files Browse the repository at this point in the history
I don't quite understand why this is flaking but I beleive it is a
test-only problem, see description in https://crbug.com/webrtc/14947
how I have trouble understanding if "frames received" is measured
correctly.

Bug: webrtc:14947, webrtc:14909
Change-Id: I667306b7cd33687645ad6a9294364330075434ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295700
Reviewed-by: Markus Handell <handellm@webrtc.org>
Auto-Submit: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39433}
  • Loading branch information
henbos authored and WebRTC LUCI CQ committed Mar 1, 2023
1 parent ba088b1 commit f6afb3f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pc/peer_connection_integrationtest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3233,8 +3233,10 @@ TEST_P(PeerConnectionIntegrationTest, OnIceCandidateErrorWithEmptyAddress) {
EXPECT_EQ(caller()->error_event().address, "");
}

// TODO(https://crbug.com/webrtc/14947): Investigate why this is flaking and
// find a way to re-enable the test.
TEST_F(PeerConnectionIntegrationTestUnifiedPlan,
AudioKeepsFlowingAfterImplicitRollback) {
DISABLED_AudioKeepsFlowingAfterImplicitRollback) {
PeerConnectionInterface::RTCConfiguration config;
config.sdp_semantics = SdpSemantics::kUnifiedPlan;
config.enable_implicit_rollback = true;
Expand Down

0 comments on commit f6afb3f

Please sign in to comment.