This repository was archived by the owner on Aug 20, 2018. It is now read-only.
Fix to PR #11 so it will work with Ruby 1.9.3 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows commands like 'new' and 'edit' that possibly contain a large amount of data (i.e. for sEvent) to not exceed the server's max length for an HTTP GET request.
|
Nice! 👍 |
szechyjs
added a commit
that referenced
this pull request
Sep 15, 2015
Fix to PR #11 so it will work with Ruby 1.9.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a small fix to @gamepoet's PR #11 so that it works with Ruby 1.9.3. In Ruby 2
Net::HTTP::Post.newcan take a uri or a path (String), but in Ruby 1.9.3 it needs to be a String. Otherwise you get a NoMethodError for URI#empty? on this line: https://github.com/ruby/ruby/blob/v1_9_3_551/lib/net/http.rb#L1861In Ruby 2.x net/http has changed a lot and it can deal with a URI being passed into the constructor for requests. Here it's calling URI#request_uri to get the path when the arg is a URI. https://github.com/ruby/ruby/blob/v2_0_0_0/lib/net/http/generic_request.rb#L19