Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add refcontent to XML reference output #26

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

stefanomunarini
Copy link
Contributor

@stefanomunarini stefanomunarini commented Jul 15, 2022

@stefanomunarini
Copy link
Contributor Author

@strogonoff the tests are failing here, but they are fixed #25 --> where other tests are broken at the same time, tho.

@stefanomunarini stefanomunarini marked this pull request as ready for review July 18, 2022 09:27
@ronaldtse
Copy link
Contributor

@stefanomunarini then how about you merge #25 into #26 then we can see tests passing?

@stefanomunarini
Copy link
Contributor Author

@ronaldtse #25 fixes the error identified here by the CI. However, in 25 I add schema validation, which fails for some datasets. Until the schema validation issue is fixed, the tests CI will always fail

@ronaldtse
Copy link
Contributor

Thanks @stefanomunarini , can you elaborate on the exact schema failures right now so we can investigate?

@stefanomunarini
Copy link
Contributor Author

stefanomunarini commented Jul 18, 2022

@ronaldtse please see #28 . And also, here you can see all the errors reported by the CI https://github.com/relaton/relaton-py/runs/7323737499?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants