Upgrade to support relay v10.0.1 #199
Conversation
thicodes
commented
Jul 24, 2020
thicodes
commented
- Sync Fixtures
- Update examples
|
Given that this contains some major updates to direct dependencies should we release a major? cc @alloy. |
| readonly __typename: string | null; | ||
| readonly id: string | null; | ||
| readonly __typename: string; | ||
| readonly id: string; |
There was a problem hiding this comment.
Why did all the nullability of these fields change? Did the test schema change?
There was a problem hiding this comment.
I think its okay to merge this snapshot, the field is non-nullable in the testschema https://github.com/facebook/relay/blob/master/packages/relay-test-utils-internal/testschema.graphql#L813
Test utils was also updated: https://github.com/relay-tools/relay-compiler-language-typescript/pull/199/files#diff-8ee2343978836a779dc9f8d6b794c3b2R5104
I can't exactly find a commit to test utils that touched the null-ability of that field. But I think its safe to push it.
There was a problem hiding this comment.
Yeah if the schema has these fields as non-nullable, then that’s good enough for me 👍
|
🚀 PR was released in v13.0.0 🚀 |
