Adds unit tests for relayOperationGenericsRule #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
reviewed
Oct 21, 2018
| Helps enforce type safety and adherence to TypeScript/Relay conventions. | ||
| Helps enforce type safety and adherence to the following TypeScript/Relay conventions: | ||
|
|
||
| - `QueryRenderer` components must include type parameters (includes fix). |
There was a problem hiding this comment.
While not test yet, this rule and fix also applies to commitMutation.
ashfurrow
added a commit
that referenced
this pull request
Oct 21, 2018
ashfurrow
added a commit
that referenced
this pull request
Oct 21, 2018
Adds more tests, follow-up from #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the
relayOperationGenericsRuleadded in #1. Fixes #2. Also updates the readme.I played around with snapshot tests but didn't like how far apart the source for linting in the test and the results were. It's more clear here that the fix is adding the import and the type parameter.
We can move
applyRuleToSourceText,applyRuleFixes, andruleOptionsinto their owntestHelpers.ts, but I wanted to get one test in as a proof-of-concept before adding CI, and then adding more rules.