proposal: arbitraryTags #113
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 72.49% 72.36% -0.13%
==========================================
Files 106 106
Lines 3537 3554 +17
==========================================
+ Hits 2564 2572 +8
- Misses 973 982 +9 ☔ View full report in Codecov by Sentry. |
v0l
reviewed
Feb 24, 2025
| // Handle arbitrary tags | ||
| arbitraryTags = {}; | ||
| map.forEach((key, value) { | ||
| if (key.startsWith('#') && |
There was a problem hiding this comment.
Dont restrict which tags are allowed, only check that it startsWith # and length == 2
| /// Map to store arbitrary/unsupported tags \ | ||
| /// Key is the tag name, value is a list of tag values | ||
| /// Unsupported tags dont offer caching support | ||
| Map<String, List<String>>? arbitraryTags; |
| // set an arbitrary tag | ||
| void setArbitraryTag(String tagName, List<String> values) { | ||
| arbitraryTags ??= {}; | ||
| arbitraryTags![tagName.startsWith('#') ? tagName : '#$tagName'] = values; |
| // get an arbitrary tag | ||
| List<String>? getArbitraryTag(String tagName) { | ||
| if (arbitraryTags == null) return null; | ||
| return arbitraryTags![tagName.startsWith('#') ? tagName : '#$tagName']; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.