-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from Travis CI to GitHub Actions #159
Comments
The token in .travis.yml has already been revoked (not rotated - so the Travis-based release workflow is simply broken now). |
Hello. I can help with this. I think we need to:
One big question remains – do we want to keep Python 2 compatibility? |
I don't want to aggressively rip out Python 2 support or intentionally make the code not work on Python 2, but if refactoring the CI I think it would be acceptable for the updated CI to not cover Python 2. |
@rohanpm Are you aware of anybody using up2date kobo with Python 2? RHEL-7 instances of Covscan use |
@kdudka using upstream kobo releases on py2 - no. My own team still has to backport recent kobo patches onto a RHEL6 build every now and then however, which at the moment usually are clean cherry-picks. It's no big deal if new kobo code only works on py3, but for existing code which might still need fixes backported to legacy systems I don't want invasive changes such as "let's upgrade all the syntax to py3-only". |
@rohanpm That makes perfect sense to me. Thank you for clarifying it! |
Thanks for making it clear. Your explanation makes perfect sense. I'll try to keep the code compatible with Python 2. |
Recommend that we switch to GitHub Actions and rotate the encrypted
password
value in.travis.yml
in light of https://arstechnica.com/information-technology/2021/09/travis-ci-flaw-exposed-secrets-for-thousands-of-open-source-projects/The text was updated successfully, but these errors were encountered: