Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from Travis CI to GitHub Actions #159

Closed
ktdreyer opened this issue Sep 20, 2021 · 7 comments · Fixed by #162
Closed

switch from Travis CI to GitHub Actions #159

ktdreyer opened this issue Sep 20, 2021 · 7 comments · Fixed by #162

Comments

@ktdreyer
Copy link
Member

ktdreyer commented Sep 20, 2021

Recommend that we switch to GitHub Actions and rotate the encrypted password value in .travis.yml in light of https://arstechnica.com/information-technology/2021/09/travis-ci-flaw-exposed-secrets-for-thousands-of-open-source-projects/

@rohanpm
Copy link
Member

rohanpm commented Sep 20, 2021

The token in .travis.yml has already been revoked (not rotated - so the Travis-based release workflow is simply broken now).
+1 on moving to Actions, this has been planned for a while already.

@frenzymadness
Copy link
Contributor

frenzymadness commented Jan 24, 2022

Hello.

I can help with this. I think we need to:

  • switch to Github actions – we can use https://github.com/fedora-python/fedora-python-tox because, in Fedora, we have the latest Python sooner than other CI systems have and Fedora is also close to the RHEL.
  • drop support for Python 3.4 and 3.5 - I think we should test versions 3.6 (main Python in RHEL 8), 3.8 (module in RHEL 8), 3.9 (module in RHEL 8, main Python in RHEL 9) and 3.10 - the latest one.
  • drop support for Django 1. We should test version 2.2 (still supported LTS, available in EPEL 8), 3.2 (current LTS version, available in Fedora) and 4 to be ready for the future LTS version.
  • and of course fix all the problems this migration discovers.

One big question remains – do we want to keep Python 2 compatibility?

@rohanpm
Copy link
Member

rohanpm commented Jan 25, 2022

I don't want to aggressively rip out Python 2 support or intentionally make the code not work on Python 2, but if refactoring the CI I think it would be acceptable for the updated CI to not cover Python 2.

@kdudka
Copy link
Contributor

kdudka commented Jan 25, 2022

@rohanpm Are you aware of anybody using up2date kobo with Python 2? RHEL-7 instances of Covscan use kobo-0.8.0. RHEL-8 instances of Covscan use Python 3.6. If there are no users of kobo running on Python 2 any more and there is no CI coverage, the support for Python 2 will break sooner or later anyway.

@rohanpm
Copy link
Member

rohanpm commented Jan 25, 2022

@kdudka using upstream kobo releases on py2 - no. My own team still has to backport recent kobo patches onto a RHEL6 build every now and then however, which at the moment usually are clean cherry-picks.

It's no big deal if new kobo code only works on py3, but for existing code which might still need fixes backported to legacy systems I don't want invasive changes such as "let's upgrade all the syntax to py3-only".

@kdudka
Copy link
Contributor

kdudka commented Jan 26, 2022

@rohanpm That makes perfect sense to me. Thank you for clarifying it!

@frenzymadness
Copy link
Contributor

Thanks for making it clear. Your explanation makes perfect sense. I'll try to keep the code compatible with Python 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants