Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New testing and CI configuration #162

Merged
merged 8 commits into from
Jan 27, 2022

Conversation

frenzymadness
Copy link
Contributor

Django 4 is not included yet because they are a lot of DeprecationWarning we have to fix first and Django 4 is still kinda fresh without LTS released yet. Moreover, Django 4 does not support Python 3.6 so it won't land in RHEL 8.

All tests pass on my local machine also in a virtual environment where rpm is available. I'm trying to accomplish the same in Github Actions, but the workflow hangs for some reason. You can see it here: https://github.com/frenzymadness/kobo/runs/4935800708?check_suite_focus=true

I don't know how to configure coverall and I probably don't have the permissions to do so so any help is appreciated.

There are a lot of changes but majority of them are very simple.

Fixes #159

@rohanpm
Copy link
Member

rohanpm commented Jan 26, 2022

About the apparent hang, if tox is run with at least -vv so it doesn't capture pip output, more relevant info can be seen e.g. in https://github.com/rohanpm/kobo/runs/4945271198

INFO: pip is looking at multiple versions of <X> to determine which version is compatible with other requirements. This could take a while.
INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. If you want to abort this run, you can press Ctrl + C to do so. To improve how pip performs, tell us what happened here: https://pip.pypa.io/surveys/backtracking

It seems genuinely quite slow and it may be necessary to follow the advice about stricter constraints.

The logs also show some missing native packages in order to compile gssapi.

@frenzymadness
Copy link
Contributor Author

Thanks for the info. The problem is indeed caused by the insufficient dependencies in the container where it's not possible to compile gssapi from source so the pip keeps trying older and older versions without any success. I'm gonna fix that and debug also other possible problems – the first one I see that we need to install also shared system mime types for tests to work properly.

@frenzymadness
Copy link
Contributor Author

It seems I have fixed all the issues, see the last run: https://github.com/frenzymadness/kobo/actions/runs/1750199687 and the last commit here.

@frenzymadness
Copy link
Contributor Author

I've opened an issue for the problem with mimetypes I've fixed here by including mailcap package in the CI container.

Copy link
Member

@rohanpm rohanpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration with coveralls or similar can be looked into as a follow-up activity at some point after this is merged.

@@ -356,6 +355,7 @@ def test_run_move_dir_with_logfile(self):
destdir = tmpdir + '.moved'
run(['mv', '-v', tmpdir, destdir], logfile=logfile, show_cmd=True)
self.assertTrue(os.path.isfile(os.path.join(destdir, 'file.log')))
shutil.rmtree(destdir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit wrong since it wouldn't be removed if the test fails.

@rohanpm rohanpm merged commit aa3e659 into release-engineering:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch from Travis CI to GitHub Actions
2 participants