-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New testing and CI configuration #162
Conversation
About the apparent hang, if tox is run with at least
It seems genuinely quite slow and it may be necessary to follow the advice about stricter constraints. The logs also show some missing native packages in order to compile gssapi. |
Thanks for the info. The problem is indeed caused by the insufficient dependencies in the container where it's not possible to compile gssapi from source so the pip keeps trying older and older versions without any success. I'm gonna fix that and debug also other possible problems – the first one I see that we need to install also shared system mime types for tests to work properly. |
It seems I have fixed all the issues, see the last run: https://github.com/frenzymadness/kobo/actions/runs/1750199687 and the last commit here. |
I've opened an issue for the problem with mimetypes I've fixed here by including mailcap package in the CI container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration with coveralls or similar can be looked into as a follow-up activity at some point after this is merged.
@@ -356,6 +355,7 @@ def test_run_move_dir_with_logfile(self): | |||
destdir = tmpdir + '.moved' | |||
run(['mv', '-v', tmpdir, destdir], logfile=logfile, show_cmd=True) | |||
self.assertTrue(os.path.isfile(os.path.join(destdir, 'file.log'))) | |||
shutil.rmtree(destdir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit wrong since it wouldn't be removed if the test fails.
Django 4 is not included yet because they are a lot of DeprecationWarning we have to fix first and Django 4 is still kinda fresh without LTS released yet. Moreover, Django 4 does not support Python 3.6 so it won't land in RHEL 8.
All tests pass on my local machine also in a virtual environment where
rpm
is available. I'm trying to accomplish the same in Github Actions, but the workflow hangs for some reason. You can see it here: https://github.com/frenzymadness/kobo/runs/4935800708?check_suite_focus=trueI don't know how to configure coverall and I probably don't have the permissions to do so so any help is appreciated.
There are a lot of changes but majority of them are very simple.
Fixes #159