Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kobo tasks might be blocked forever #260

Closed
kdudka opened this issue Apr 29, 2024 · 1 comment · Fixed by #261
Closed

kobo tasks might be blocked forever #260

kdudka opened this issue Apr 29, 2024 · 1 comment · Fixed by #261

Comments

@kdudka
Copy link
Contributor

kdudka commented Apr 29, 2024

As pointed out by @lzaoral, kobo tasks that produce output on their stdout/stderr might be blocked forever if the logging thread is killed and its queue becomes full.

@rohanpm
Copy link
Member

rohanpm commented May 1, 2024

Can we clarify the "logging thread is killed" scenario?

If this refers to the "Fatal error in LoggingThread" path where an exception is allowed to propagate from the thread's main loop: I guess this can be fixed by having that path adjust self such that any later calls to the write method will discard the data rather than putting it on the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants