fix: handle pre-release version properly #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelmbagira
force-pushed
the
fix/prerelease-latest-version
branch
from
db9acf2 to
9c305b8
Compare
micaelmbagira
force-pushed
the
fix/prerelease-latest-version
branch
from
e2c0050 to
fc54f73
Compare
|
@webpro could you please give it a look? |
| tagPrefix: options.tagPrefix, | ||
| skipUnstable: true, | ||
| cwd: options.cwd | ||
| }); |
There was a problem hiding this comment.
Ideally the tag could be returned by conventionalRecommendedBump but it's not...
|
Thanks @micaelmbagira! This has been release in v8.0.2-next.0, feel free to try it out. Would love to get your feedback before releasing v8.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
The solution is inspired from #92 but simplified and with unit tests.