Fix version URLs in gitlab repos #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re range - Add head option, defaults to 'HEAD' - Use the value of head option where HEAD was hardcoded - Add a test with custom head
eMarek
approved these changes
Jan 9, 2021
eMarek
reviewed
Jan 9, 2021
| @@ -28,3 +28,4 @@ In [release-it](https://github.com/release-it/release-it) config: | |||
| | addUnreleased | `false` | It leaves "Unreleased" title row if set to `true`. | | |||
| | keepUnreleased | `false` | It leaves "Unreleased" title row unchanged if set to `true`. | | |||
| | addVersionUrl | `false` | Links the version to the according changeset. | | |||
| | head | `'HEAD'` | The git revision the new version tag is compared to in the Unreleased URL. | | |||
There was a problem hiding this comment.
If you don't mind, could you please wrap CHANGELOG.md on line 26 into single quotes as 'CHANGELOG.md'. The same way as you made for 'HEAD' . Thanks!
There was a problem hiding this comment.
Sure, already done ;-)
|
@webpro please merge and make a new release if it looks okay to you. |
|
Sorry for the late reply! Thanks @tamaracha and @eMarek for this. Just released as v2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gitlab, the compare tool doesn't accept HEAD in the revision range, only tags and branches are allowed. This PR adds the possibility to configure the name of the head revision in an additional plugin option, so the plugin can also generate version URLs for gitlab repos.