Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only retrieve details for tables and not views #6

Merged
merged 2 commits into from
Nov 1, 2016

Conversation

bassco
Copy link
Contributor

@bassco bassco commented Nov 1, 2016

Generation crashes when a view is retrieved from the database.

Generation crashes when a view is retrieved from the database.
Copy link
Member

@CristianLlanos CristianLlanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! Thanks.

@@ -78,8 +78,9 @@ protected function load()
*/
protected function fetchTables($schema)
{
$rows = $this->connection->select('SHOW TABLES FROM '.$schema);
$tables = Arr::flatten($rows);
$rows = $this->connection->select('SHOW FULL TABLES FROM '.$schema.' WHERE Table_type=\'BASE TABLE\'');
Copy link
Member

@CristianLlanos CristianLlanos Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing :) I've just added a method wrap to add backticks to the schema name which seems to have been representing a problem (#5). Please, would you mind rebasing the new changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry. I can resolve the conflicts after merging anyway :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I'm not able to do that :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to merge it :D

@CristianLlanos CristianLlanos merged commit b651ce1 into reliese:master Nov 1, 2016
@bassco
Copy link
Contributor Author

bassco commented Nov 2, 2016

Sweet!

On 1 November 2016 at 22:33, Cristian Llanos notifications@github.com
wrote:

@CristianLlanos commented on this pull request.

In src/Meta/MySql/Schema.php #6:

@@ -78,8 +78,9 @@ protected function load()
*/
protected function fetchTables($schema)
{

  •    $rows = $this->connection->select('SHOW TABLES FROM '.$schema);
    
  •    $tables = Arr::flatten($rows);
    
  •    $rows = $this->connection->select('SHOW FULL TABLES FROM '.$schema.' WHERE Table_type=\'BASE TABLE\'');
    

I managed to merge it :D


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBjvYYtBWE5uIiBSUByhCowzO6Bm6mQks5q56INgaJpZM4KmejC
.

@pqthang97 pqthang97 mentioned this pull request Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants