-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only retrieve details for tables and not views #6
Conversation
Generation crashes when a view is retrieved from the database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice! Thanks.
@@ -78,8 +78,9 @@ protected function load() | |||
*/ | |||
protected function fetchTables($schema) | |||
{ | |||
$rows = $this->connection->select('SHOW TABLES FROM '.$schema); | |||
$tables = Arr::flatten($rows); | |||
$rows = $this->connection->select('SHOW FULL TABLES FROM '.$schema.' WHERE Table_type=\'BASE TABLE\''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing :) I've just added a method wrap
to add backticks to the schema name which seems to have been representing a problem (#5). Please, would you mind rebasing the new changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry. I can resolve the conflicts after merging anyway :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I'm not able to do that :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to merge it :D
Sweet! On 1 November 2016 at 22:33, Cristian Llanos notifications@github.com
|
Generation crashes when a view is retrieved from the database.